pkg/35930: checkperms fails on Linux 2.4

[uli%habel.name@localhost]

>Number:         35930
>Category:       pkg
>Synopsis:       checkperms fails on Linux 2.4
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 05 21:40:00 +0000 2007
>Originator:     Ulrich Habel
>Release:        Linux 2.4 (Debian Sarge)
>Organization:
-
>Environment:
Linux newton 2.4.27-3-686 #1 Tue Dec 5 21:03:54 UTC 2006 i686 GNU/Linux
>Description:
sysutils/checkperms fails on Linux (Debian Sarge 2.4) with the following build 
error:

=> Required installed package digest>=20010302: digest-20060826 found
===> Skipping vulnerability checks.
WARNING: No /usr/pkgsrc/distfiles/pkg-vulnerabilities file found.
WARNING: To fix, install the pkgsrc/security/audit-packages
WARNING: package and run: ``/usr/pkg/sbin/download-vulnerability-list''.
=> Checksum SHA1 OK for checkperms-1.4.tar.gz
=> Checksum RMD160 OK for checkperms-1.4.tar.gz
===> Installing dependencies for checkperms-1.4nb1
=> Required installed package gcc>=2.95.3nb7: gcc-2.95.3nb7 found
===> Overriding tools for checkperms-1.4nb1
===> Extracting for checkperms-1.4nb1
===> Patching for checkperms-1.4nb1
===> Creating toolchain wrappers for checkperms-1.4nb1
===> Configuring for checkperms-1.4nb1
===> Building for checkperms-1.4nb1
gcc -O2 -I/usr/pkg/include  -Wall -Wstrict-prototypes -Wmissing-prototypes 
-Wpointer-arith -Wno-uninitialized -Wreturn-type -Wcast-qual -Wpointer-arith 
-Wwrite-strings -Wswitch -Wshadow -Werror  -I/usr/pkg/include -c checkperms.c
cc1: warnings being treated as errors
In file included from /usr/include/string.h:375,
                 from checkperms.c:32:
/usr/include/bits/string2.h: In function `__strcpy_small':
/usr/include/bits/string2.h:441: warning: pointer of type `void *' used in 
arithmetic
/usr/include/bits/string2.h:449: warning: pointer of type `void *' used in 
arithmetic
/usr/include/bits/string2.h:454: warning: pointer of type `void *' used in 
arithmetic
/usr/include/bits/string2.h:459: warning: pointer of type `void *' used in 
arithmetic
/usr/include/bits/string2.h:461: warning: pointer of type `void *' used in 
arithmetic
/usr/include/bits/string2.h:466: warning: pointer of type `void *' used in 
arithmetic

[wrapper.sh] note: The real command line, after the pkgsrc wrapper, was:
/usr/pkgsrc/sysutils/checkperms/work/.gcc/bin/gcc -O2 
-I/usr/pkgsrc/sysutils/checkperms/work/.buildlink/include -Wall 
-Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-uninitialized 
-Wreturn-type -Wcast-qual -Wpointer-arith -Wwrite-strings -Wswitch -Wshadow 
-Werror -c checkperms.c -L/usr/pkgsrc/sysutils/checkperms/work/.buildlink/lib 
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/sysutils/checkperms/work/checkperms-1.4
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/sysutils/checkperms
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/sysutils/checkperms

>How-To-Repeat:
Try to build sysutils/checkperms on Debian Linux Sarge
>Fix:
I think this is more a Linux issue than a problem with pkgsrc. The problem 
seems to be located in /usr/include/bits/string2.h of the Linux Debian 
distribution. The following patch in unified diff format to the Makefile of 
sysutils/checkperms set gcc to treat warnings not as errors and the package can 
be build.

--- Makefile.orig       2006-10-07 00:55:10.000000000 +0200
+++ Makefile    2007-03-05 21:12:50.000000000 +0100
@@ -4,4 +4,13 @@
 PROG=  checkperms
 WARNS= 4
 
+# Linux breaks this build due to a
+# buggy string2.h - so we need to
+# set NOGCCERROR to treat warnings
+# not as errors
+#
+#ifdef __linux__
+NOGCCERROR=    1
+#endif
+
 .include <bsd.prog.mk>