>Number:         35214
>Category:       pkg
>Synopsis:       lang/spidermonkey/buildlink3.mk missing include
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Dec 09 00:20:00 +0000 2006
>Originator:     Brandon Bergren
>Release:        N/A
>Organization:
>Environment:
Linux overbeck 2.6.17.4-linode23 #1 Thu Jul 13 23:24:40 EDT 2006 i686 prescott i386 GNU/Linux
>Description:
The latest change to lang/spidermonkey/buildlink3.mk broke my elinks build (I make elinks depend on spidermonkey on my site so I can get javascript support)

In short, checking OPSYS without including bsd.prefs.mk is a bad idea.

Patch attached.
>How-To-Repeat:
Attempt to build elinks (which doesn't need to pull in bsd.prefs.mk) with spidermonkey support (by including the ../../lang/buildlink3.mk file)
>Fix:
Index: buildlink3.mk
===================================================================
RCS file: /cvsroot/pkgsrc/lang/spidermonkey/buildlink3.mk,v
retrieving revision 1.7
diff -u -r1.7 buildlink3.mk
--- buildlink3.mk       8 Aug 2006 21:08:14 -0000       1.7
+++ buildlink3.mk       9 Dec 2006 00:06:47 -0000
@@ -11,6 +11,8 @@
 BUILDLINK_PACKAGES+=   spidermonkey
 BUILDLINK_ORDER:=      ${BUILDLINK_ORDER} ${BUILDLINK_DEPTH}spidermonkey

+.include "../../mk/bsd.prefs.mk"
+
 .if !empty(SPIDERMONKEY_BUILDLINK3_MK:M+)
 BUILDLINK_API_DEPENDS.spidermonkey+=   spidermonkey>=1.5
 .if ${OPSYS} == "Darwin"