Re: pkg/35108

[simon%bigblue.demon.co.uk@localhost]

The following reply was made to PR pkg/35108; it has been noted by GNATS.

From: simon%bigblue.demon.co.uk@localhost
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/35108
Date: Sat, 25 Nov 2006 17:34:38 +0000 (GMT)

 >Submitter-Id: net
 >Originator:   
 >Organization:
        
 >Confidential: no
 >Synopsis:     devel/bmake fails during build
 >Severity:     serious
 >Priority:     low
 >Category:     pkg
 >Class:                sw-bug
 >Release:      NetBSD 4.99.3
        
        
 >Environment:
        
        
 System: NetBSD magnet 4.99.3 NetBSD 4.99.3 (GENERIC.MPACPI) #0: Mon Nov 6 
19:01:05 UTC 2006 
builds@pb:/home/builds/ab/HEAD/i386/200611060000Z-obj/home/builds/ab/HEAD/src/sys/arch/i386/compile/GENERIC.MPACPI
 i386
 Architecture: i386
 Machine: i386
 >Description:
        as per PR35108
        
 >How-To-Repeat:
        
 >Fix:
        
        patch files included.
 
        the missing sys.mk file is found under /usr/share/mk on NetBSD, however
        if using bootstrap the file is found under ${PREFIX}/share/mk.
        Makefile revs prior to 1.28 showed makesyspath as
        
makesyspath=${PREFIX}/share/mk:/usr/share/mk:/usr/local/share/mk:/opt/share/mk
        I assumed that the /usr/local and /opt paths are not relevant to NetBSD
        /usr/share and ${PREFIX}/share should cover the default install and
        bootsrap pkgsrc.
 
        in Makefile.in lowering WARN=2 was to enable completion of the build.
        compat.c would warn that vfork might clobber several variables in 
        function CompatRunCommand. There exists a #ifdef __GNUC__ to prevent 
        the warning, however it would appear that gcc 4 is no longer 
        fooled by it.
 
        this was tested on 4.99.3/i386 using pkgsrc20061111 and under 
        pkg_comp having run bootstrap to populate /usr/pkg/share/mk.
        Also tested on FreeBSD 5.4 with same pkgsrc.
 
        testing included using the new bmake to compile devel/zlib
 
 
 --- Makefile.orig      2006-11-25 12:59:04.000000000 +0000
 +++ Makefile   2006-11-25 14:37:51.000000000 +0000
 @@ -18,7 +18,14 @@
  NO_CHECKSUM=  yes
  NO_MTREE=     yes
  
 +.include "../../mk/bsd.prefs.mk"
 +
 +.if ${OPSYS:MNetBSD}
 +makesyspath=  ${PREFIX}/share/mk:/usr/share/mk
 +.else
  makesyspath=  ${PREFIX}/share/mk
 +.endif
 +
  
  INSTALLATION_DIRS=    bin ${PKGMANDIR}/man1
  
 @@ -35,7 +42,7 @@
  
  do-install:
        ${INSTALL_PROGRAM} ${WRKDIR}/${OPSYS}/bmake ${PREFIX}/bin
 -      ${INSTALL_MAN} ${WRKDIR}/${OPSYS}/bmake.1 ${PREFIX}/${PKGMANDIR}/man1
 +      ${INSTALL_MAN} ${WRKSRC}/bmake.1 ${PREFIX}/${PKGMANDIR}/man1
  
  .if defined(LIBNBCOMPAT_STYLE) && (${LIBNBCOMPAT_STYLE} == "inplace")  
  .  include "../../pkgtools/libnbcompat/inplace.mk"
 
 
 
 
 --- files/Makefile.in.orig     2006-11-25 14:47:28.000000000 +0000
 +++ files/Makefile.in  2006-11-25 14:53:25.000000000 +0000
 @@ -50,7 +50,7 @@
  # Don't set these for anyone else since we don't know what the effect may be.
  # On FreeBSD WARNS=2 sets a bunch of -W flags that make does not handle.
  WFORMAT= 1
 -WARNS=3
 +WARNS=2
  .NOPATH: bmake.cat1
  .if make(install) && exists(${DESTDIR}/usr/share/doc)
  SUBDIR=       PSD.doc