pkg/35035: print/ja-vfxdvik: check-portability failed

[Ryo HAYASAKA <ryoh%jaist.ac.jp@localhost>]

>Number:         35035
>Category:       pkg
>Synopsis:       print/ja-vfxdvik: check-portability failed
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Nov 11 13:15:00 +0000 2006
>Originator:     Ryo HAYASAKA
>Release:        NetBSD 4.99.3, pkgsrc-current
>Organization:
Japan Advanced Institute of Science and Technology (JAIST)
>Environment:
System: NetBSD bonnie.jaist.ac.jp 4.99.3 NetBSD 4.99.3 (BONNIE) #633: Mon Nov 6 
23:46:13 JST 2006 
ryoh%bonnie.jaist.ac.jp@localhost:/usr/src/sys/arch/i386/compile/BONNIE i386
Architecture: i386
Machine: i386
>Description:
Checking for portability problems fails as follows:

$ make
...
===> configure-message [ja-vfxdvik-22.40v.j1.14nb9] ===> Configuring for 
ja-vfxdvik-22.40v.j1.14nb9
=> Checking for portability problems in extracted files
ERROR: [check-portability.awk] => Found test ... == ...:
ERROR: [check-portability.awk] libs/libwww/configure:      if test 
"$ac_cv_func_remove" == yes ; then

Explanation:
===========================================================================
The "test" command, as well as the "[" command, are not required to know
the "==" operator. Only a few implementations like bash and some
versions of ksh support it.

When you run "test foo == foo" on a platform that does not support the
"==" operator, the result will be "false" instead of "true". This can
lead to unexpected behavior.

There are two ways to fix this error message. If the file that contains
the "test ==" is needed for building the package, you should create a
patch for it, replacing the "==" operator with "=". If the file is not
needed, add its name to the CHECK_PORTABILITY_SKIP variable in the
package Makefile.
===========================================================================

*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/print/ja-vfxdvik
        
>How-To-Repeat:
        
>Fix:
$NetBSD$

--- libs/libwww/configure.orig  2003-01-17 10:31:56.000000000 +0900
+++ libs/libwww/configure
@@ -7668,7 +7668,7 @@ else
   echo "$ac_t""no" 1>&6
 fi

-     if test "$ac_cv_func_remove" == yes ; then
+     if test "$ac_cv_func_remove" = yes ; then
         cat >> confdefs.h <<\EOF
 #define unlink remove
 EOF