Subject: pkg/34943: removing compiler warnings in pkgsrc/pkgtools/pkg_install
To: None <,,>
From: Eric Schnoebelen <>
List: pkgsrc-bugs
Date: 10/29/2006 22:15:00
>Number:         34943
>Category:       pkg
>Synopsis:       remove compiler warnings in pkgsrc/pkgtools/pkg_install
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Oct 29 22:15:00 +0000 2006
>Originator:     Eric Schnoebelen
>Release:        HP-UX B.11.11
Eric Schnoebelen
  "The nice thing about Windows is - It does not just crash, it 
   displays a dialog box and lets you press 'OK' first." - Arno Schaefer
HP-UX peake B.11.11 A 9000/785 2006709503 two-user license
  B3899BA       B.11.11.06      HP C/ANSI C Developer's Bundle for HP-UX 11.i (S700) 
  B3911DB       C.03.37.01      HP aC++ Compiler (S700)
  FEATURE11-11  B.11.11.0209.5  Feature Enablement Patches for HP-UX 11i, Sept 2002  
  HPUX11i-TCOE  B.11.11.0306    HP-UX Technical Computing OE Component
  HPUXBase64    B.11.11         HP-UX 64-bit Base OS
  HPUXBaseAux   B.11.11.0312    HP-UX Base OS Auxiliary
  HWEnable11i   B.11.11.0312.4  Hardware Enablement Patches for HP-UX 11i v1, December 2003

[ok, the above is only really useful/interesting to an HP-UX weenie, or
the HP WTEC.]
        Several source files declare function prototypes as static
at the top, and then fail to repeat the static keyword when declaring
the actual function.
        compile with a very picky compiler, such as HP ANSI C.
Index: files/delete/perform.c
RCS file: /cvsroot/pkgsrc/pkgtools/pkg_install/files/delete/perform.c,v
retrieving revision 1.16
diff -b -u -w -r1.16 perform.c
--- files/delete/perform.c	30 May 2005 13:23:31 -0000	1.16
+++ files/delete/perform.c	29 Oct 2006 22:10:32 -0000
@@ -263,7 +263,7 @@
  * Delete from directory 'home' all packages on lpkg_list. 
  * If tryall is set, ignore errors from pkg_delete(1).
+static int
 require_delete(char *home, int tryall)
 	lpkg_t *lpp;
@@ -362,7 +362,7 @@
  * Recursively find all packages "up" the tree (follow +REQUIRED_BY). 
  * Return 1 on errors
+static int
 require_find_recursive_up(lpkg_t *thislpp)
 	lpkg_head_t reqq;
@@ -441,7 +441,7 @@
  * Recursively find all packages "down" the tree (follow @pkgdep). 
  * Return 1 on errors
+static int
 require_find_recursive_down(lpkg_t *thislpp, package_t *plist)
 	plist_t *p;
@@ -562,7 +562,7 @@
  * Start recursion in the one or other direction. 
+static int
 require_find(char *pkg, rec_find_t updown)
 	lpkg_t *lpp;
@@ -585,7 +585,7 @@
 	return (rv);
+static void
 	lpkg_t *lpp;