Subject: pkg/34941: clean up prototype mis-matches in pkgsrc/archivers/pax
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: None <eric@cirr.com>
List: pkgsrc-bugs
Date: 10/29/2006 22:10:02
>Number:         34941
>Category:       pkg
>Synopsis:       quiet compiler warnings by correcting prototype mismatches
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Oct 29 22:10:01 +0000 2006
>Originator:     Eric Schnoebelen
>Release:        HP-UX B.11.11
>Organization:
Eric Schnoebelen		eric@cirr.com		http://www.cirr.com
  "The nice thing about Windows is - It does not just crash, it 
   displays a dialog box and lets you press 'OK' first." - Arno Schaefer
>Environment:
HP-UX peake B.11.11 A 9000/785 2006709503 two-user license
  B3899BA       B.11.11.06      HP C/ANSI C Developer's Bundle for HP-UX 11.i (S700)
  B3911DB       C.03.37.01      HP aC++ Compiler (S700)
  FEATURE11-11  B.11.11.0209.5  Feature Enablement Patches for HP-UX 11i, Sept 2002
  HPUX11i-TCOE  B.11.11.0306    HP-UX Technical Computing OE Component
  HPUXBase64    B.11.11         HP-UX 64-bit Base OS
  HPUXBaseAux   B.11.11.0312    HP-UX Base OS Auxiliary
  HWEnable11i   B.11.11.0312.4  Hardware Enablement Patches for HP-UX 11i v1, December 2003

[ok, the above is only really useful/interesting to an HP-UX weenie, or
the HP WTEC.]

>Description:
	Several source files declare function prototypes as static
at the top, and then fail to repeat the static keyword when declaring
the actual function.
>How-To-Repeat:
	compile with a very picky compiler, such as HP ANSI C.
>Fix:
cvs diff: Diffing .
cvs diff: Diffing files
Index: files/ar_io.c
===================================================================
RCS file: /cvsroot/pkgsrc/archivers/pax/files/ar_io.c,v
retrieving revision 1.9
diff -b -u -w -r1.9 ar_io.c
--- files/ar_io.c	1 Dec 2005 03:00:01 -0000	1.9
+++ files/ar_io.c	29 Oct 2006 22:05:16 -0000
@@ -1635,7 +1635,7 @@
  * to keep the fd the same in the calling function (parent). possible
  * programs are GZIP_CMD, BZIP2_CMD, and COMPRESS_CMD.
  */
-void
+static void
 ar_start_gzip(int fd, const char *gzp, int wr)
 {
 	int fds[2];
Index: files/options.c
===================================================================
RCS file: /cvsroot/pkgsrc/archivers/pax/files/options.c,v
retrieving revision 1.8
diff -b -u -w -r1.8 options.c
--- files/options.c	1 Dec 2005 03:00:01 -0000	1.8
+++ files/options.c	29 Oct 2006 22:05:16 -0000
@@ -2007,7 +2007,7 @@
 	return(num);
 }
 
-char *
+static char *
 getline(FILE *f)
 {
 	char *name, *temp;
@@ -2048,7 +2048,7 @@
  *	print the usage summary to the user
  */
 
-void
+static void
 pax_usage(void)
 {
 	fprintf(stderr,
@@ -2077,7 +2077,7 @@
  *	print the usage summary to the user
  */
 
-void
+static void
 tar_usage(void)
 {
 	(void)fputs("usage: tar [-]{crtux}[-befhjlmopqvwzHOPSXZ014578] [archive] "
@@ -2094,7 +2094,7 @@
  *	print the usage summary to the user
  */
 
-void
+static void
 cpio_usage(void)
 {