Subject: Re: pkg/34642
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
List: pkgsrc-bugs
Date: 10/20/2006 11:45:02
The following reply was made to PR pkg/34642; it has been noted by GNATS.

From: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/34642
Date: Fri, 20 Oct 2006 13:41:36 +0200

 --envbJBWh7q8WU6mo
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 This error is because of a namespace pollution in
 main/sparse/make_sparse.h, the two attached patches remove that
 namespace pollution and make octave-forge build with gcc4.
 
 --envbJBWh7q8WU6mo
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=patch-local-ab
 
 --- main/sparse/make_sparse.cc.orig	2006-10-20 12:58:09.000000000 +0200
 +++ main/sparse/make_sparse.cc	2006-10-20 12:58:23.000000000 +0200
 @@ -321,7 +321,7 @@
                 // if args(5) is not string, then ignore the value
                 // otherwise check for summation or unique
                 if ( args(5).is_string()) {
 -                  string vv= args(5).string_value();
 +                  std::string vv= args(5).string_value();
  		  if (error_state) return retval;
  
                    if ( vv== "summation" ||
 
 --envbJBWh7q8WU6mo
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=patch-local-aa
 
 --- main/sparse/make_sparse.h.orig	2006-10-20 12:53:46.000000000 +0200
 +++ main/sparse/make_sparse.h	2006-10-20 12:54:36.000000000 +0200
 @@ -209,8 +209,6 @@
  
  #include <string>
  
 -using namespace std;
 -
  class ostream;
  
  #ifdef NEED_OCTAVE_QUIT
 
 --envbJBWh7q8WU6mo--