Subject: pkg/34591: Patch file that fixed DNS lookup problems in www/dillo was mistakenly removed in CVS
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: None <dhgutteridge@sympatico.ca>
List: pkgsrc-bugs
Date: 09/23/2006 04:35:00
>Number:         34591
>Category:       pkg
>Synopsis:       Patch file that fixed DNS lookup problems in www/dillo was mistakenly removed in CVS
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Sep 23 04:35:00 +0000 2006
>Originator:     David H. Gutteridge
>Release:        
>Organization:
>Environment:
>Description:
The patch file I submitted in PR31205 and committed by Tim Rightnour (garbled@) was removed in more recent changes to www/dillo.  I'm not sure why, presumably by accident.  It was needed to fix DNS query lockups in older versions of NetBSD that didn't have reentrant resolver functions.

In any case, dillo now provides an option in its configure script that allows the threaded DNS feature to be disabled, so here's my attempt at a new patch that takes advantage of this.  (I'm not able to test it, unfortunately, as everything I have is running > 3.0.  I did have a 1.6.2 box, but it had a hardware failure.)

(This isn't quite as precise with the NetBSD version as my old patch, but I would assume impacts to users running 2.99.x would be minimal.)


>How-To-Repeat:

>Fix:
--- Makefile~	2006-09-22 22:43:11.000000000 -0400
+++ Makefile	2006-09-23 00:17:02.000000000 -0400
@@ -21,6 +21,11 @@
 
 .include "options.mk"
 
+# NetBSD < 3.0 does not have reentrant resolver functions
+.if ${OPSYS} == "NetBSD" && !empty(OS_VERSION:M[1-2].*)
+CONFIGURE_ARGS+=	--disable-threaded-dns
+.endif
+
 post-install:
 	${INSTALL_DATA_DIR} ${PREFIX}/share/doc/dillo
 	${INSTALL_DATA} ${WRKSRC}/doc/*.txt ${PREFIX}/share/doc/dillo