Subject: PR/34231 CVS commit: pkgsrc/net/openntpd
To: None <,,,>
From: Peter Postma <>
List: pkgsrc-bugs
Date: 08/20/2006 14:55:03
The following reply was made to PR pkg/34231; it has been noted by GNATS.

From: Peter Postma <>
Subject: PR/34231 CVS commit: pkgsrc/net/openntpd
Date: Sun, 20 Aug 2006 14:50:43 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	peter
 Date:		Sun Aug 20 14:50:43 UTC 2006
 Modified Files:
 	pkgsrc/net/openntpd: Makefile distinfo
 Log Message:
 Update openntpd version 3.9p1.
 Submitted by Shaun Amott in PR/34231.
 Changes since previous version in pkgsrc:
  - (dtucker) [ includes.h ntp_msg.c] Add UnixWare support.  Based
    on patch from luke.bakken at
  - (dtucker) [version.h] Release 3.9.
  - (dtucker) [openbsd-compat/fake-rfc2553.c] Missing braces in initializer.
  - (dtucker) [] Correctly fall back to builtin-arc4random when
    OpenSSL is not present.
  - (dtucker) [INSTALL ntp.c] Make configure --with-privsep-path
    compile in the chroot directory.  Default behavior remains to chroot to
    the ntpd user's home dir.  Based in part on a patch from OpenWall via
    solar at openwall com.
  - (dtucker) [] Make rebuild of parse conditional.
  - (dtucker) [ defines.h] Enable replacement getifaddrs via
    ioctl on Linux.
  - (dtucker) [ openbsd-compat/fake-rfc2553.{c,h}] Add in6addr_any if
    system libraries don't have it.
  - (dtucker) [ openbsd-compat/bsd-misc.c] Add null implementation
    of strsignal().
  - (dtucker) [openbsd-compat/openbsd-compat.h] Template for strsignal.
  - (dtucker) OpenBSD CVS Sync
   - 2005/07/06 19:54:24
     add another non-fatal error for recvfrom; ok henning@
     (ID sync only, already in portable)
   - 2005/07/11 18:04:28
     Print actual error when in debug mode; ok henning@
   - 2005/07/11 18:05:34
     Print privsep user and dir when in debug mode; ok henning@
   - 2005/07/11 18:08:06
     More descriptive error if a signal causes the child to exit; ok henning@
   - 2005/07/15 13:34:52
     fix a function name in an error message why this was rotting in my
     tree for so long, I dunno - and I dunno where it came from
   - 2005/07/15 13:36:10
     remove recently added "using privsep user X" message, spams console
     in -s mode, noticed by kettenis
   - 2005/07/15 13:37:15
     shrink read buffer size from 64k to 4k, this is not bgpd and we're
     dealing with way less data
   - 2005/07/22 18:58:56
     Skip invalid interfaces during 'listen on *'; ok henning@
   - 2005/08/09 00:42:32
     with -s, do not wait if we don't have any peers at all.  From: Thomas
     Jarosch <>
   - 2005/08/10 23:48:36
     [client.c ntp.c ntpd.h server.c]
     Propogate server's leap indicator flags to clients; ok henning@
   - 2005/08/12 02:21:52
     check for EINTR too after writev(), pt out by Alexander Farber
   - 2005/08/12 02:26:29
     on writing, we actually can deal with ENOBUFS just as well as with
     EAGAIN and EINTR, so do it, more or less from bgpd
   - 2005/09/07 07:27:10
     when running ntpd with "-s" as it's argument from /etc/rc.conf, make
     sure the output goes to syslog and not console by moving around log_init
   - 2005/09/24 10:32:03
     [client.c ntp_msg.c ntpd.h server.c]
     Log source address for 'malformed packet' errors.  ok henning@
   - 2006/01/19 17:40:16
     Check SA_LEN(sa) after sa is checked for NULL.  Pointed out by solar
     at, ok henning@
   - 2006/01/19 22:20:23
     Do not attempt to listen on interfaces with a wildcard address;
     ok henning@
  - (dtucker) [] Skip OpenSSL checks for cross-compilation.  Found
    and tested by Scott Hays.
  - (dtucker) [openbsd-compat/bsd-setres[ug]id.c] Add code to use setre[ug]id
    and some sanity checks.
  - (dtucker) [] Alphabetize $host case block.
  - (dtucker) [ server.c openbsd-compat/
    openbsd-compat/bsd-getifaddrs.{c,h} openbsd-compat/openbsd-compat.h]
    Add getifaddrs() to compat layer.  Not enabled by default on any platform
    now, enable with -DGETIFADDRS_VIA_SIOCGIFCONF at your own risk.
  - (dtucker) [client.c] recvfrom on HP-UX will return EADDRNOTAVAIL instead
    of ECONNREFUSED for a port-unreachable, so add to the non-fatal error
  - (dtucker) OpenBSD CVS Sync
   - 2005/07/05 20:09:12
     [client.c ntp.c ntpd.h server.c]
     Save transmit time for each peer for later use as refid for SNTPv4
     replies.  ok henning@
  - (dtucker) OpenBSD CVS Sync
   - 2005/03/23 11:42:04
     [imsg.c ntpd.h]
     wpos in struct buf_read and datalen in imsg_get should be size_t and
     not ssize_t From: Alexander von Gernler <>
   - 2005/03/23 12:36:35
     remove now osolete comment, from a mail exchange with Alexander von
     Gernler <>
   - 2005/03/24 11:56:22
     fatal vs fatalx, Alexander von Gernler
   - 2005/03/24 15:50:07
     one more fatal/fatalx, alexander
   - 2005/03/31 12:14:01
     zap includes, Alexander von Gernler <>
   - 2005/03/31 17:02:43
     zap includes, grunk
   - 2005/04/18 11:06:35
     prevent replies with negative delay from being used, could happen with
     -s From: Joerg Sonnenberger <> of dragonfly
   - 2005/04/18 11:07:55
     after setting the clock hard correct the "next" and "deadline" timestamps
     by the offset From: Joerg Sonnenberger <>
   - 2005/04/18 14:12:50
     correctness: only account for offset after settime in next and deadline
     when those timers are actually running. due to the way ntpd's logic
     works this does not really make a difference, but correctness is good.
     spotted by me, joerg agrees
   - 2005/04/18 20:46:02
     extra paranoia, from a discussion with joerg
   - 2005/04/19 11:08:41
     move the "reply from ... " log msg in -d mdoe uop a bit so it actually
     comes before the "adjusting local clock by..." one, joerg
   - 2005/04/26 15:18:22
     [buffer.c imsg.c ntpd.h]
     unify shared code a bit again to make future syncs easier From:
     Alexander von Gernler <>
   - 2005/05/03 05:44:35
     setres[ug]id; ok deraadt@
   - 2005/05/11 15:12:35
     don't touch *hn in failure case. no real change due to the way we use
     it but more correct.  from  Michael Knudsen <>
   - 2005/05/24 08:46:43
     no need for endpwent(0 here either
   - 2005/05/25 06:10:50
     ifa->ifa_addr can be NULL in some cases, pt out by Kurt Roeckx
     <> /
   - 2005/05/26 19:13:06
     [ntp.c ntpd.c]
     Ensure previous adjust has completed before clearing alarm flag;
     ok henning@
   - 2005/06/20 02:42:57
     [client.c ntp.c ntpd.c ntpd.h parse.y]
     use a little state engine to keep track of delayed dns lookups and such,
     eases things tested by Jason Ackley <> Matthias Kilian
     <> Stephen Marley <> sturm@
     theo ok
   - 2005/06/20 03:11:13
     [ntpd.c ntpd.h]
     use a #define for the time to wait on -s and clarify a log msg
   - 2005/06/22 05:55:18
     [ntpd.8] (ID sync only; section is not in portable man page)
     we do not do -s in /etc/rc anymore.  this is because, even if -s did
     try to do it's job it would have to choose between two cases: 1. either
     it would take a very long time to get the correct adjustment, thus,
        if you are not currently on the net right, you wait a long time
        (or must type ^C, which is ridiculous)
     2. ntpd could be modified to "abort early", but then would not meet the
        promise made by -s in the manual page (note: it does not say that it
     therefore, -s and -S must become user choices.  Sorry.  This same
     choice is made in lots of other places
  - (dtucker) [LICENCE openbsd-compat/
    openbsd-compat/bsd-setres[ug]id.c openbsd-compat/openbsd-compat.h
    removed openbsd-compat/uidswap.c] Use setres[ug]id interface on all
    platforms.  Currently only implements the case where ruid == euid == suid
    which is all ntpd uses (may be extended later).
  - (dtucker) [] Use example ntpd.conf from srcdir so "make install"
    works for the srcdir != builddir.
  - (dtucker) [openbsd-compat/{bsd-poll.c,bsd-setresgid.c,bsd-setresuid.c}]
    Add CVS Ids
  - (dtucker) [ openbsd-compat/{,errx.c,verrx.c,
     openbsd-compat.h}] Add errx(), in anticipation of it being used in ntpd.
  - (dtucker) [INSTALL] Add a bit more detail on the privsep user and group.
  - (dtucker) [README] Make it clear that the footnote only applies to old
    Solaris systems, based on feedback from oyvind at
  - (dtucker) [INSTALL] Point out that --with-ssl-dir is only used if
    we're not using the builtin arc4random.
  - (dtucker) [INSTALL] Add installation directions, lack thereof pointed out
    by oyvind at
  - (dtucker) [] Have configure find a yacc that works.
  - (dtucker) [] Make check for existing ntp user more specific.
  - (dtucker) [openbsd-compat/bsd-poll.c] Remove code left over from debugging.
  - (dtucker) [] Check that required programs are found.  Pointed
    out by jj at
  - (dtucker) [contrib/redhat/openntpd.spec] If ntp user already exists,
    set its homedir to the chroot dir.  From wijnand at
  - (dtucker) [contrib/redhat/openntpd.spec] Always create privsep dir
    even if ntp user already exists.  Also from Wijnand.
  - (dtucker) [ mdoc2man.awk] Add support for other
    man page formats (man and catman), based on OpenSSH's.
  - (dtucker) [ openbsd-compat/] Make out-of-tree
    builds work.
  - (dtucker) [ openbsd-compat/] Minor cleanups.
  - (dtucker) [LICENCE] Add Anil Madhavapeddy to atomicio bits.
  - (dtucker) [version.h] Set version to -current.
  - (dtucker) [openbsd-compat/atomicio.c openbsd-compat/atomicio.h
     openbsd-compat/bsd-arc4random.c] Sync OpenBSD ssize_t -> size_t atomicio
     change by avsm@, update rnd code to new interface.
  - (dtucker) [openbsd-compat/bsd-poll.c] Portability and correctness fixes:
   - Handle fd == -1 case.
   - Handle fractional second timeouts correctly (not used in ntpd).
   - Allow any negative timeout to mean INFTIM.
  - (dtucker) [] For AC_CHECK_HEADERS() and AC_CHECK_FUNCS() have
    one entry per line to make it easier to merge changes.
  - (dtucker) [defines.h includes.h openbsd-compat/bsd-poll.c] Copyright bump.
  - (dtucker) [CREDITS includes.h version.h] Add CVS Id.
  - (dtucker) [openbsd-compat/asprintf.c] char const -> const char, matches
    OpenBSD 1.10 -> 1.11.
 To generate a diff of this commit:
 cvs rdiff -r1.17 -r1.18 pkgsrc/net/openntpd/Makefile
 cvs rdiff -r1.6 -r1.7 pkgsrc/net/openntpd/distinfo
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.