>Number:         34185
>Category:       pkg
>Synopsis:       games/kdegames3 3.5.4 Solaris10
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Aug 11 14:20:00 +0000 2006
>Originator:     Gilles Dauphin
>Release:        SunOS 5.10 i86pc
>Organization:
ENST 
>Environment:


System: SunOS bi.enst.fr 5.10 Generic_Patch_118844-30 i86pc


>Description:


gmake[2]: Leaving directory `/pkg/obj/games/kdegames3/work/kdegames-3.5.4/kmines/solver'
gmake[2]: Entering directory `/pkg/obj/games/kdegames3/work/kdegames-3.5.4/kmines'
gmake[3]: Entering directory `/pkg/obj/games/kdegames3/work/kdegames-3.5.4/kmines'
test -z "/usr/pkg/bin" || /bin/bash ../admin/mkinstalldirs "/usr/pkg/bin"
  /bin/bash ../libtool --silent --mode=install /usr/ucb/install -c -s -o root -g root -m 555 'kmines' '/usr/pkg/bin/kmines'
/usr/pkg/bin/gmake  install-exec-hook
gmake[4]: Entering directory `/pkg/obj/games/kdegames3/work/kdegames-3.5.4/kmines'
/bin/bash: -c: line 2: syntax error near unexpected token `'
/bin/bash: -c: line 2: `|| echo "Error: Could not install the game with correct permissions !!" \'
gmake[4]: *** [install-exec-hook] Error 2
gmake[4]: Leaving directory `/pkg/obj/games/kdegames3/work/kdegames-3.5.4/kmines'
gmake[3]: *** [install-exec-am] Error 2
gmake[3]: Leaving directory `/pkg/obj/games/kdegames3/work/kdegames-3.5.4/kmines'
gmake[2]: *** [install-am] Error 2
gmake[2]: Leaving directory `/pkg/obj/games/kdegames3/work/kdegames-3.5.4/kmines'
gmake[1]: *** [install-recursive] Error 1
gmake[1]: Leaving directory `/pkg/obj/games/kdegames3/work/kdegames-3.5.4/kmines'
gmake: *** [install-recursive] Error 1
*** Error code 2

Stop.



>How-To-Repeat:


bmake install


>Fix:


in Makefile.in look at install-exec-hook:

Problem is the nested '((' and '))' for some SHELL
and the '!!' in the echo message 

impacted games:
kdegames-3.5.4/kmines
kdegames-3.5.4/klickety
kdegames-3.5.4/kfouleggs
kdegames-3.5.4/ksirtet/ksirtet

------------patch example-------------------

--- kdegames-3.5.4/ksirtet/ksirtet/Makefile.in.orig     Mon Jul 24 17:08:56 2006
+++ kdegames-3.5.4/ksirtet/ksirtet/Makefile.in  Fri Aug 11 16:10:23 2006
@@ -871,31 +871,31 @@
 
 install-exec-hook:
        @(test x$(HIGHSCORE_DIRECTORY) != x \
-        && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+        && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
        || echo "Error: Could not install the game with correct permissions !!" \
-       )) || true
+       ) ) || true
 
        @(test x$(HIGHSCORE_DIRECTORY) != x \
-               && ((mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
-               && chmod 750 $(DESTHIGHSCORES)) \
+               && ( (mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
+               && chmod 750 $(DESTHIGHSCORES) ) \
        || echo "Error: Could not create the highscore directory with correct permissions !!" \
-       )) || true
+       ) ) || true
 
        @(test x$(HIGHSCORE_DIRECTORY) != x \
-        && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+        && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
        || echo "Error: Could not install the game with correct permissions !!" \
-       )) || true
+       ) ) || true
 
        @(test ${setgid} = true \
-        && ((chmod 2755  $(DESTBIN)) \
+        && ( (chmod 2755  $(DESTBIN) ) \
        || echo "Error: Could not install the game with correct permissions !!" \
-       )) || true
+       ) ) || true
 
        @(test x$(HIGHSCORE_DIRECTORY) != x \
-        && ((touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
-       && chmod 0660 $(DESTSCORES)) \
+        && ( (touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
+       && chmod 0660 $(DESTSCORES) ) \
        || echo "Error: Could not create system-wide highscore file with correct permissions !!" \
-       )) || true
+       ) ) || true
 # Tell versions [3.59,3.63) of GNU make to not export all variables.
 # Otherwise a system limit (for SysV at least) may be exceeded.
 .NOEXPORT: