pkg/34086: "make update" cleans the directory on errors

[rillig%NetBSD.org@localhost]

>Number:         34086
>Category:       pkg
>Synopsis:       "make update" cleans the directory on errors
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 26 06:10:00 +0000 2006
>Originator:     Roland Illig
>Release:        NetBSD 3.0_STABLE
>Organization:
        
>Environment:
        
        
System: NetBSD bacc.roland-illig.de 3.0_STABLE NetBSD 3.0_STABLE (GENERIC) #0: 
Sat Jun 17 13:16:17 CEST 2006 
build%baccf5ee.roland-illig.de@localhost:/home/build/3/2006-06/i386/work/sys/arch/i386/compile/GENERIC
 i386
Architecture: i386
Machine: i386
>Description:

Until the last few weeks, when "make update" failed for whatever reason,
the working directories of the packages were not cleaned up so that the
user could inspect what was going wrong.

Currently, the working directories are cleaned even if the build fails or
some files could not be installed.

>How-To-Repeat:

        make update PKG_FAIL_REASON="make update fails"

>Fix:

Only clean up the working directory if building and installing the
package has succeeded.

>Unformatted: