Subject: pkg/33975: grammar police in pkgsrc/mk/pkginstall/shell
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: None <dholland@eecs.harvard.edu>
List: pkgsrc-bugs
Date: 07/11/2006 13:15:00
>Number:         33975
>Category:       pkg
>Synopsis:       grammar police in pkgsrc/mk/pkginstall/shell
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 11 13:15:00 +0000 2006
>Originator:     David A. Holland <dholland@eecs.harvard.edu>
>Release:        NetBSD 3.99.21 (pkgsrc of 20060710)
>Organization:
   Harvard EECS
>Environment:
System: NetBSD tanaqui 3.99.21 NetBSD 3.99.21 (TANAQUI) #4: Fri Jun 16 11:23:47 EDT 2006 dholland@tanaqui:/usr/src/sys/arch/i386/compile/TANAQUI i386
Architecture: i386
Machine: i386
>Description:
When you uninstall a shell, it says

   Removing shells from $PKG to /etc/shells:
                             ^^

English being highly idiomatic, you don't say "remove to", only
"remove from".

>How-To-Repeat:
	n/a
>Fix:

Index: mk/pkginstall/shell
===================================================================
RCS file: /cvsroot/pkgsrc/mk/pkginstall/shell,v
retrieving revision 1.1
diff -u -r1.1 shell
--- mk/pkginstall/shell	21 May 2006 23:50:15 -0000	1.1
+++ mk/pkginstall/shell	11 Jul 2006 13:11:51 -0000
@@ -85,7 +85,7 @@
 			yes)	;;
 			*)	printed_header=yes
 				${ECHO} "==========================================================================="
-				${ECHO} "Adding shells from ${PKGNAME} to $shelldb:"
+				${ECHO} "Adding ${PKGNAME} shells to $shelldb:"
 				${ECHO} ""
 				;;
 			esac
@@ -126,7 +126,7 @@
 			yes)	;;
 			*)	printed_header=yes
 				${ECHO} "==========================================================================="
-				${ECHO} "Removing shells from ${PKGNAME} to $shelldb:"
+				${ECHO} "Removing ${PKGNAME} shells from $shelldb:"
 				${ECHO} ""
 				;;
 			esac