Subject: Re: PR/32945 CVS commit: pkgsrc/devel/gettext-lib
To: None <joerg@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,>
From: Gilles Dauphin <Gilles.Dauphin@enst.fr>
List: pkgsrc-bugs
Date: 07/06/2006 07:50:04
The following reply was made to PR pkg/32945; it has been noted by GNATS.
From: Gilles Dauphin <Gilles.Dauphin@enst.fr>
To: minskim@NetBSD.org
Cc: gnats-bugs@NetBSD.org
Subject: Re: PR/32945 CVS commit: pkgsrc/devel/gettext-lib
Date: Thu, 6 Jul 2006 09:46:10 +0200 (CEST)
> >
> > This patch break gettext-lib on Solaris.
> > locale_charset is *not* define in the native iconv library.
> > Original patch in PR 32945 seems good (#ifndef __APPLE__ ...)
> > here is the patch i want and maybe use CFLAGS.Darwin+= -
> > D__LOCALE_CHARSET__
> > in Makefile
>
> I want to avoid platform-dependent fixes if possible. How about
> defining locale_charset only when GNU iconv is used? See the
> attached patches.
>
> Regards,
> Min
>
That's ok for me. I like your patch :)
Regards
Gilles