pkg/33811: Problem with mk/install/install.mk

[darren%mambo.net@localhost]

        Note: There was a bad value `' for the field `Class'.
        It was set to the default value of `sw-bug'.

        Note: There was a bad value `' for the field `Priority'.
        It was set to the default value of `medium'.

        Note: There was a bad value `' for the field `Severity'.
        It was set to the default value of `serious'.

>Number:         33811
>Category:       pkg
>Synopsis:       'make update' can fail because NO_MTREE unset and MTREE unset
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jun 24 04:00:00 +0000 2006
>Originator:     Darren Holloway
>Release:        NetBSD 2.0.2
>Organization:
        
>Environment:
        
        
System: NetBSD mambo1.mambo.net 2.0.2 NetBSD 2.0.2 (GENERIC) #0: Wed Mar 23 
08:53:42 UTC 2005 
jmc%faith.netbsd.org@localhost:/home/builds/ab/netbsd-2-0-2-RELEASE/i386/200503220140Z-obj/home/builds/ab/netbsd-2-0-2-RELEASE/src/sys/arch/i386/compile/GENERIC
 i386
Architecture: i386
Machine: i386
>Description:
Discovered when updating /usr/pkgsrc/graphics/png from 1.2.8 to 1.2.10
'sudo make update' failed with: "-U: command not found"
Traced problem to /usr/pkgsrc/mk/install/install.mk line 213 
(/^install-makedirs/+2)

-- code --
MTREE_FILE?=    ${PKGSRCDIR}/mk/platform/${OPSYS}.pkg.dist
MTREE_ARGS?=    -U -f ${MTREE_FILE} -d -e -p

.PHONY: install-makedirs
install-makedirs:
        ${_PKG_SILENT}${_PKG_DEBUG}${TEST} -d ${PREFIX} || ${MKDIR} ${PREFIX}
.if !defined(NO_MTREE)
        ${_PKG_SILENT}${_PKG_DEBUG}${TEST} ! -f ${MTREE_FILE} ||        \
                ${MTREE} ${MTREE_ARGS} ${PREFIX}/
.endif
-- end code --

${MTREE} is obviously unset here, which causes the -U of MTREE_ARGS to be
run as a command.

I don't know enough (okay, anything really) about pkgsrc, so I can't trace
what the root cause is.

Comment out the lines between .if and .endif
        
>How-To-Repeat:
cd /usr/pkgsrc/graphics/png
sudo make update
        
>Fix:
        
Comment out the lines between .if and .endif
Probably has unintended side effects ;)

>Unformatted: