Subject: pkg/33770: [patch] multimedia/xine-lib does not build on FreeBSD
To: None <,,>
From: None <>
List: pkgsrc-bugs
Date: 06/19/2006 22:35:00
>Number:         33770
>Category:       pkg
>Synopsis:       [patch] multimedia/xine-lib does not build on FreeBSD
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 19 22:35:00 +0000 2006
>Originator:     Peter Schuller
>Release:        FreeBSD 6.1
FreeBSD 6.1-RELEASE FreeBSD 6.1-RELEASE #4: Fri May 26 22:40:45 CEST 2006  i386

xine-lib does not build on FreeBSD 6.1:

input_cdda.c: In function `read_cdrom_frames':
input_cdda.c:693: error: storage size of 'cdda' isn't known
input_cdda.c:710: error: `CDIOCREADAUDIO' undeclared (first use in this function)
input_cdda.c:710: error: (Each undeclared identifier is reported only once
input_cdda.c:710: error: for each function it appears in.)
input_cdda.c:693: warning: unused variable `cdda'

The reason is that SYS_PARAM_H is checked instead of HAVE_SYS_PARAM_H, which leads to __FreeBSD_version not being defined which in turn leads to the wrong code being chosen by the pre-processor.

Patch is here:

The post-patch package has been tested to build on FreeBSD 6.1 and NetBSD 3.0:ish.