Subject: pkg/33037: nbcompat/err.h header file incomplete?
To: None <,,>
From: None <>
List: pkgsrc-bugs
Date: 03/09/2006 11:10:00
>Number:         33037
>Category:       pkg
>Synopsis:       nbcompat/err.h header file incomplete?
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Mar 09 11:10:00 +0000 2006
>Originator:     Stuart Shelton

libnbcompat-20041024's err.h library seems, so far as I can tell, to be incomplete: It uses the __P macro and va_list without including the relevent headers.

I'm not a C expert, so I might have misunderstood how this header is supposed to be used ... but shouldn't the following change be applied:

 # include <err.h>

+# include <nbcompat/cdefs.h>
+#ifndef __STDARG_H__
+# include <stdarg.h>
 #if !HAVE_ERR
 void    err __P((int, const char *, ...));
 void    errx __P((int, const char *, ...));
 void    verr __P((int, const char *, va_list));