pkg/33022: the include directories are ordered improperly for psi

[smb%cs.columbia.edu@localhost]

>Number:         33022
>Category:       pkg
>Synopsis:       the include directories are ordered improperly for psi
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 07 04:55:00 +0000 2006
>Originator:     Steven M. Bellovin
>Release:        NetBSD 3.99.16
>Organization:
        
>Environment:
        
        
System: NetBSD gg1.cs.columbia.edu 3.99.16 NetBSD 3.99.16 (GG1) #0: Sun Mar 5 
13:38:44 EST 2006 
smb%gg1.cs.columbia.edu@localhost:/usr/BUILD/obj/sys/arch/i386/compile/GG1 i386
Architecture: i386
Machine: i386
>Description:
        When you build chat/psi, you end up with compilation lines like
        this:

        c++ -c -O2 -I/usr/pkgsrc/chat/psi/work/.buildlink/include \
        -I/usr/pkg/qt3/include -DGLX_GLXEXT_LEGACY \
        -I/usr/pkgsrc/chat/psi/work/.x11-buildlink/include \
        -I/usr/pkgsrc/chat/psi/work/.buildlink/include/freetype2 \
        -DQ_TRAILING_DIR_SEP -D_REENTRANT -DHAVE_XSS -DHAVE_CONFIG \
        -DXMPP_TEST -DQT_NO_DEBUG -DQT_THREAD_SUPPORT \
        -I/usr/pkg/qt3/mkspecs/netbsd-g++ -I. \
        -I../../../../../../pkg/include -I../cutestuff/util \
        -I../cutestuff/network -Itools/trayicon -Itools/idle \
        -Itools/systemwatch -Itools/mac_dock -Itools/zip \
        -Itools/dirwatch -Itools/openpgp -Itools/globalaccel \
        -Itools/advwidget -I../iris/include -I../iris/xmpp-core \
        -I../iris/xmpp-im -I../iris/jabber -I../libpsi/iconset \
        -I../libpsi/psiwidgets -I../libpsi/psipng \
        -I../../../../../../pkg/xorg/include -I.ui/ -Ioptions \
        -I.moc/../iris/xmpp-core/connector.cpp -fPIC -DPIC \
        -o .obj/.libs/connector.o

        (\\n inserted for readability).
        The problem is that /usr/pkg/include comes too soon.
        If net/socks5 is installed, it creates pkg/include/socks.h
        which conflicts with cutestuff/network/socks.h that
        connector.cpp uses, thus causing compilation failures.

>How-To-Repeat:
        cd /usr/pkgsrc/net/socks5 && make install &&
        cd /usr/pkgsrc/chat/psi && make
>Fix:
        The work-around is to install socks5 later, or to hand-edit
        the line with the -I files.  Probably, some pkgsrc magic needs
        to be done to make it behave properly in the first place.

>Unformatted: