Subject: pkg/32977: games/pysol requires python <=22
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: None <kre@munnari.OZ.AU>
List: pkgsrc-bugs
Date: 03/03/2006 11:50:00
>Number:         32977
>Category:       pkg
>Synopsis:       games/pysol requires python <=22
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 03 11:50:00 +0000 2006
>Originator:     Robert Elz
>Release:        NetBSD 3.99.15  (pkgsrc current as of a couple of hours ago)
>Organization:
	Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 3.99.15 NetBSD 3.99.15 (GENERIC-1.696-20060125) #8: Wed Jan 25 04:59:39 ICT 2006 kre@jade.coe.psu.ac.th:/usr/obj/current/kernels/JADE_ASUS i386
	Building using pkg_comp with libkver & NetBSD 3.0 release sets
	(but that isn't relevant to this PR)
Architecture: i386
Machine: i386
>Description:
	games/pysol has no PYTHON_VERSIONS_ACCEPTED in its Makefile,
	yet it only works with python22 (or before)

>How-To-Repeat:
	Have python23 (or 24) as your default (and installed) python
	and install games/pysol - then try to run it.   It fails
	looking for a script file appropriate for the version of
	python being used - it has scripts for versions of python
	up to 2.2 - but nothing later.

>Fix:
	The patch below fixes it.    Alternatively, find out whether
	the 2.2 stuff would work with 2.3 (or 2.4) and if so, make
	(by copying presumably) scripts for those versions.  In any
	case a PYTHON_VERSIONS_ACCEPTED declaration is going to be
	needed, as otherwise it will just fail again when a new version
	of python appears, if that one gets picked as the default.

	A workaround is to have python22 and py22-Tk installed, and then
	make a one character change to /usr/pkg/bin/pysol (so it looks
	for python22 instead of python23 (or 24)).   That's what I've been
	doing for the past year or more - i expected omeone else would
	notice this and fix it long before now...

Index: Makefile
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/games/pysol/Makefile,v
retrieving revision 1.23
diff -u -r1.23 Makefile
--- Makefile	5 Feb 2006 23:09:21 -0000	1.23
+++ Makefile	3 Mar 2006 11:31:03 -0000
@@ -17,6 +17,8 @@
 
 CARDSETS=	pysol-cardsets-4.40
 
+PYTHON_VERSIONS_ACCEPTED=       22 21
+
 INSTALLATION_DIRS=	bin man/man6
 
 do-install: