>Number:         32942
>Category:       pkg
>Synopsis:       Crash bug in pkgsrc ap-php-4.4.1nb5
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 27 10:45:00 +0000 2006
>Originator:     Neil Hoggarth
>Release:        Solaris 9
>Organization:
University of Oxford
>Environment:
SunOS saros 5.9 Generic_118558-19 sun4u sparc SUNW,Ultra-30

>Description:
PHP 4.4.1 has a known bug when used with Apache 2, causing the Apache
server to segfault if the Apache "ErrorDocument" directive us used to
serve a PHP page:

  http://bugs.php.net/bug.php?id=35056

There is a one line fix given in the above PHP bug report. This fix is
incorporated into PHP 4.4.2.

Would it be possible to either pull-up PHP 4.4.2 into pkgsrc, or incorporate the fix as a pkgsrc patch for 4.4.1?


>How-To-Repeat:

>Fix:
--- www/ap-php/work/php-4.4.1/sapi/apache2handler/sapi_apache2.c~	Wed Oct 12 22:41:36 2005
+++ www/ap-php/work/php-4.4.1/sapi/apache2handler/sapi_apache2.c	Mon Feb 27 10:39:57 2006
@@ -535,7 +535,7 @@
 		if (!parent_req) {
 			parent_req = ctx->r;
 		}
-		if (parent_req && strcmp(parent_req->handler, PHP_MAGIC_TYPE) && strcmp(parent_req->handler, PHP_SOURCE_MAGIC_TYPE) && strcmp(parent_req->handler, PHP_SCRIPT)) {
+		if (parent_req && parent_req->handler && strcmp(parent_req->handler, PHP_MAGIC_TYPE) && strcmp(parent_req->handler, PHP_SOURCE_MAGIC_TYPE) && strcmp(parent_req->handler, PHP_SCRIPT)) {
 			if (php_apache_request_ctor(r, ctx TSRMLS_CC)!=SUCCESS) {
 				zend_bailout();
 			}