Subject: pkg/32850: xlockmore/Makefile.common needs option to disable vroot (tvtwm)
To: None <,,>
From: None <>
List: pkgsrc-bugs
Date: 02/16/2006 03:35:00
>Number:         32850
>Category:       pkg
>Synopsis:       xlockmore needs option to disable vroot mode.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Feb 16 03:35:00 +0000 2006
>Originator:     George Michaelson
>Release:        NetBSD 3.99.15
George Michaelson       |  APNIC                 
Email:    |  PO Box 2131 Milton    
Phone: +61 7 3858 3150  |  QLD 4064 Australia    
  Fax: +61 7 3858 3199  |  
System: NetBSD 3.99.15 NetBSD 3.99.15 (GGMSMALL) #0: Thu Feb 9 14:35:52 EST 2006 i386
Architecture: i386
Machine: i386
	tvtwm has a really broken vroot model. Although coders historically
	have used a vroot.h to get around it, some applications (xv, and 
	xlockmore notably) just can't do it right.

	xlockmore provides a configure option --disable-vroot which
	'dtrt' when you use tvtwm.
	run tvtwm.
	compile/install xlockmore
	run with two heads. xlock doesn't blank screen, mouse
	still moves, but until p/w is typed, kb is locked. no
	prompt screen, no message. its a real denyal-of-service
	This patch to Makefile.common should do it, at the cost
	of a new option in mk.conf.
$ cvs diff Makefile.common 
Index: Makefile.common
RCS file: /cvsroot/pkgsrc/x11/xlockmore/Makefile.common,v
retrieving revision 1.41
diff -u -p -r1.41 Makefile.common
--- Makefile.common     12 Jan 2006 19:37:44 -0000      1.41
+++ Makefile.common     16 Feb 2006 03:24:14 -0000
@@ -76,6 +76,10 @@ CONFIGURE_ARGS+=     --without-dpms
 CONFIGURE_ARGS+=       --disable-allow-root
+.if !empty(PKG_OPTIONS:Mxlockmore-disable-vroot)
+CONFIGURE_ARGS+=       --disable-vroot
 .include "../../mk/"
 # Set the complete paths to the sound files and set the default xlock