Re: pkg/32835: rc.d/estd doesn't have the 'x' bit set

[Johnny Lam <jlam%pkgsrc.org@localhost>]

Steven M. Bellovin wrote:
> It has that near the bottom, but a 'make install' shows
>
> ===> Installing for estd-0.4nb1
> install -d -o root -g wheel -m 0755 /usr/pkg/sbin
> install -s -o root -g wheel -m 0755 estd /usr/pkg/sbin/estd
> install -d -o root -g wheel -m 0755 /usr/pkg/man/man1
> install -o root -g wheel -m 0644 estd.1 /usr/pkg/man/man1/estd.1
> install -o root -g wheel -m 0644 estd.sh /usr/pkg/share/examples/rc.d/estd
> ===> [Automatic manual page handling]
> ===> Registering installation for estd-0.4nb1
>
> and
>
> # ls -l /usr/pkg/share/examples/rc.d/estd
> -rw-r--r--  1 root  wheel  322 Feb 14 16:21 /usr/pkg/share/examples/rc.d/estd

The sysutils/estd/patches/patch-aa file is incorrect.  Firstly, it 
should be using the BSD_INSTALL_* macros, otherwise, this package will 
not install correctly when UNPRIVILEGED=yes.  Secondly, it should be 
installing the rc.d script using BSD_INSTALL_SCRIPT instead of 
hardcoding to mode 0644.

        Cheers,

        -- Johnny Lam <jlam%pkgsrc.org@localhost>