Subject: Re: pkg/32803: multimedia/xvidcore builds not just on i386 [with patches]
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: None <joerg@britannica.bec.de>
List: pkgsrc-bugs
Date: 02/12/2006 14:30:04
The following reply was made to PR pkg/32803; it has been noted by GNATS.
From: joerg@britannica.bec.de
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/32803: multimedia/xvidcore builds not just on i386 [with patches]
Date: Sun, 12 Feb 2006 15:28:52 +0100
On Sun, Feb 12, 2006 at 02:00:01PM +0000, Rhialto wrote:
> --- Makefile.orig 2006-02-12 14:38:53.000000000 +0100
> +++ Makefile 2006-02-12 14:39:08.000000000 +0100
> @@ -11,10 +11,6 @@
> HOMEPAGE= http://www.xvid.org/
> COMMENT= ISO MPEG-4 compliant video codec
>
> -ONLY_FOR_PLATFORM+= *-*-i386
> -
> -BUILD_DEPENDS+= nasm>=0.98.34:../../devel/nasm
> -
> PKG_INSTALLATION_TYPES= overwrite pkgviews
>
> WRKSRC= ${WRKDIR}/${DISTNAME}/build/generic
This is not fully correct. nasm is needed on amd64 and i386 to get the
optimised assembly, it is much slower otherwise.
> To eliminate a bunch of warnings:
I like neither this version nor original. Please complain upstream to
check for uintptr_t and intptr_t as defined by POSIX and only define
them as fallback. I don't think removing them is appropiate since it
will break some older platforms.
Joerg