Subject: pkg/32658: dvdbackup fails to compile
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: None <none@netbsd.org, given@netbsd.org>
List: pkgsrc-bugs
Date: 01/28/2006 22:50:01
>Number:         32658
>Category:       pkg
>Synopsis:       dvdbackup fails to compile
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 28 22:50:00 +0000 2006
>Originator:     none given
>Release:        -current
>Organization:
none given
>Environment:
any
>Description:
The libdvdread include files included by dvdbackup.c will hit a #error if stdint.h (or similar) isn't included first.



>How-To-Repeat:
cd /usr/pkgsrc/graphics/dvdbackup
make all

>Fix:
--- dvdbackup/src/dvdbackup.c.orig	2002-08-04 23:08:39.000000000 -0700
+++ work/dvdbackup/src/dvdbackup.c	2006-01-28 14:32:47.000000000 -0800
@@ -21,6 +21,7 @@
 
 #include <stdio.h>
 #include <stdlib.h>
+#include <stdint.h>
 #include <string.h>
 #include <sys/errno.h>
 #include <errno.h>
@@ -782,7 +783,7 @@
 	 to consider the second one a feature title we are doing two checks (biggest  + biggest - second) /second == 1
 	 and biggest%second * 3 < biggest */
 
-	if ( CheckSizeArray(size_size_array, 0, 1)  == 1 ) {
+	if ( title_sets > 1 && CheckSizeArray(size_size_array, 0, 1)  == 1 ) {
 		/* We have a dual DVD with two feature films - now lets see if they have the same amount of chapters*/
 
 		chapters_1 = 0;