Subject: Re: pkg/31205 (Patch for dillo 0.8.5 to handle NetBSD releases without re-en
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: David H.Gutteridge <dhgutteridge@sympatico.ca>
List: pkgsrc-bugs
Date: 01/08/2006 05:55:02
The following reply was made to PR pkg/31205; it has been noted by GNATS.
From: David H.Gutteridge <dhgutteridge@sympatico.ca>
To: <gnats-bugs@netbsd.org>
Cc: <garbled@netbsd.org>
Subject: Re: pkg/31205 (Patch for dillo 0.8.5 to handle NetBSD releases without re-en
Date: Sun, 8 Jan 2006 0:54:11 -0500
This is a multi-part message in MIME format.
------=____1136699651841_V4cz)-69RR
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 7bit
Apologies, you're right, it actually makes no difference at all! I'd copied
my fix from related patches for Mozilla/Firefox, but what I didn't realize
was that in Dillo's case, there are no includes that ever end up pulling in
sys/param.h indirectly, so that patch was useless. (I thought it made a
difference based on personal surfing I tested it with, but my approach
wasn't rigourous. If I had just enabled a higher debug level in the
source file in question, I would have seen right away that the threaded
version was still running. Duh!)
This new patch I've attached actually works, and it looks like it makes an
appreciable difference. Sorry to waste your time before.
Dave
--- src/dns.c.orig 2006-01-08 00:26:22.000000000 +0000
+++ src/dns.c 2006-01-08 00:27:16.000000000 +0000
@@ -38,7 +38,14 @@
/*
* Note: comment the following line for debugging or gprof profiling.
*/
-#define G_DNS_THREADED
+#ifdef __NetBSD__
+# include <sys/param.h>
+# if __NetBSD_Version__ >= 299000900
+# define G_DNS_THREADED
+# endif
+#else
+# define G_DNS_THREADED
+#endif
/*
* Uncomment the following line for libc5 optimization
>
> From: garbled@netbsd.org
> Date: 2005/12/31 Sat AM 01:18:39 EST
> To: pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org,
> gnats-admin@netbsd.org, garbled@netbsd.org, dhgutteridge@sympatico.ca
> Subject: Re: pkg/31205 (Patch for dillo 0.8.5 to handle NetBSD releases without re-entrant resolver functions)
>
>
------=____1136699651841_V4cz)-69RR
Content-Transfer-Encoding: base64
Content-Type: null;
name="reply"
Content-Disposition: inline;
filename="reply"
U3lub3BzaXM6IFBhdGNoIGZvciBkaWxsbyAwLjguNSB0byBoYW5kbGUgTmV0QlNEIHJlbGVh
c2VzIHdpdGhvdXQgcmUtZW50cmFudCByZXNvbHZlciBmdW5jdGlvbnMNCg0KU3RhdGUtQ2hh
bmdlZC1Gcm9tLVRvOiBvcGVuLT5mZWVkYmFjaw0KU3RhdGUtQ2hhbmdlZC1CeTogZ2FyYmxl
ZEBuZXRic2Qub3JnDQpTdGF0ZS1DaGFuZ2VkLVdoZW46IFNhdCwgMzEgRGVjIDIwMDUgMDY6
MTg6MzQgKzAwMDANClN0YXRlLUNoYW5nZWQtV2h5Og0KSSB3YXMgYWJsZSB0byByZXByb2R1
Y2UgdGhlIHByb2JsZW0gb24gbXkgMi4wL2kzODYgbWFjaGluZS4gIEkgYXBwbGllZCB0aGUN
CnN1cHBsaWVkIHBhdGNoLCBhbmQgdGhlIHByb2JsZW0gZGlkIG5vdCBnbyBhd2F5LiAgKEl0
IGFjdHVhbGx5IGxvb2tzIGxpa2UNCml0IGdvdCB3b3JzZSkuDQoNCkRvIHlvdSBoYXZlIGEg
YmV0dGVyIGZpeCBmb3IgdGhpcz8NCg0KDQo=
------=____1136699651841_V4cz)-69RR--