Subject: pkg/32323: Prototypes for digest's prototypes in sha2.h
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: None <lkundrak@skosi.org>
List: pkgsrc-bugs
Date: 12/17/2005 18:00:00
>Number: 32323
>Category: pkg
>Synopsis: Prototypes for digest's prototypes in sha2.h
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: pkg-manager
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sat Dec 17 18:00:00 +0000 2005
>Originator: Lubomir Kundrak
>Release: pkgsrc-current
>Organization:
>Environment:
Linux lurker 2.6.12-10-k7 #1 Fri Nov 18 12:46:18 UTC 2005 i686 GNU/Linux
Ubuntu 5.10
gcc (GCC) 4.0.2 20050808 (prerelease) (Ubuntu 4.0.1-4ubuntu9)
>Description:
pkgsrc fails to bootstrap on ubuntu linux with gcc-4 (and possibly others) because of wrong prototypes in digest's sha2.h. (pkgtools/digest/files/sha2.h)
patch for some is attached, but possibly other prototypes are wrong, and thus need to be reviewed
>How-To-Repeat:
./bootstrap
>Fix:
102c102,103
< char* SHA256_Data(const u_int8_t*, size_t, u_char *);
---
> char* SHA256_Data(const u_char *, size_t, u_char *);
>
109c110
< char* SHA384_Data(const u_int8_t*, size_t, char[SHA384_DIGEST_STRING_LENGTH]);
---
> char* SHA384_Data(const u_char*, size_t, char[SHA384_DIGEST_STRING_LENGTH]);
116c117
< char* SHA512_Data(const u_int8_t*, size_t, char[SHA512_DIGEST_STRING_LENGTH]);
---
> char* SHA512_Data(const u_char*, size_t, char[SHA512_DIGEST_STRING_LENGTH]);