Subject: pkg/32029: add gtk option to net/ettercap
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: Geert Hendrickx <ghen@telenet.be>
List: pkgsrc-bugs
Date: 11/09/2005 18:51:00
>Number:         32029
>Category:       pkg
>Synopsis:       add gtk option to net/ettercap
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Nov 09 18:51:00 +0000 2005
>Originator:     Geert Hendrickx
>Release:        NetBSD 3.0_BETA
>Organization:
>Environment:
System: NetBSD lori.mine.nu 3.0_BETA NetBSD 3.0_BETA (LORI) #0: Sat Oct 8 13:42:03 CEST 2005 geert@lori.mine.nu:/cvs/obj/sys/arch/i386/compile/LORI i386
Architecture: i386
Machine: i386
>Description:
For those who even bother running X programs as root, here is a "gtk" option
for net/ettercap, to optionally build the GTK frontend (it's the same binary,
just invoke it as ettercap -G).  

I'm not sure how to name the option though, x11, gtk, or gtk2.  I chose gtk
because it's in the options.description file, whereas gtk2 isn't.  
>How-To-Repeat:
>Fix:
Index: Makefile
===================================================================
RCS file: /pub/NetBSD-CVS/pkgsrc/net/ettercap/Makefile,v
retrieving revision 1.37
diff -u -r1.37 Makefile
--- Makefile	14 May 2005 16:46:17 -0000	1.37
+++ Makefile	9 Nov 2005 18:47:38 -0000
@@ -13,10 +13,10 @@
 CONFLICTS+=		ettercap-NG-[0-9]*
 
 GNU_CONFIGURE=		yes
-CONFIGURE_ARGS+=	--enable-plugins \
-			--enable-https \
-			--disable-gtk
+CONFIGURE_ARGS+=	--enable-plugins
+CONFIGURE_ARGS+=	--enable-https
 
+.include "options.mk"
 
 USE_NCURSES=		# putwin()
 USE_OLD_DES_API=	yes
Index: options.mk
===================================================================
RCS file: options.mk
diff -N options.mk
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ options.mk	9 Nov 2005 18:47:38 -0000
@@ -0,0 +1,11 @@
+PKG_OPTIONS_VAR=	PKG_OPTIONS.ettercap
+PKG_SUPPORTED_OPTIONS=	gtk
+
+.include "../../mk/bsd.options.mk"
+
+.if !empty(PKG_OPTIONS:Mgtk)
+CONFIGURE_ARGS+=	--enable-gtk
+.include "../../x11/gtk2/buildlink3.mk"
+.else
+CONFIGURE_ARGS+=	--disable-gtk
+.endif