Hello,

At Thu, 6 Oct 2005 06:18:28 -0700,
Ben Collver wrote:
> 
> I have committed a fix for pkg/31443 to cvs.  Would you update
> audio/faad2 to the latest version and verify that it solves the problem?
> 
Thanks.  I can compile the test program.  However, the other
problems have appeared.

I've added an inclusion of audio/faad2/buildlink3.mk to the
audio/gtkpod/Makefile of my local tree.  But this package can't
compile with the audio/faad2.

# cd /usr/pkgsrc/audio/gtkpod
# vi Makefile [add inclusion of audio/faad2/buildlink3.mk]
# make
[snip]
In file included from /usr/pkgsrc/audio/gtkpod/work/.buildlink/include/faad2/mpeg4ip.h:28,
                 from /usr/pkgsrc/audio/gtkpod/work/.buildlink/include/faad2/mp4.h:27,
                 from mp4file.c:136:
/usr/pkgsrc/audio/gtkpod/work/.buildlink/include/faad2/systems.h:228: warning: redefinition of `__in_port_t'
/usr/include/sys/ansi.h:47: warning: `__in_port_t' previously declared here
/usr/pkgsrc/audio/gtkpod/work/.buildlink/include/faad2/systems.h:232: warning: redefinition of `__socklen_t'
/usr/include/sys/ansi.h:52: warning: `__socklen_t' previously declared here
/usr/pkgsrc/audio/gtkpod/work/.buildlink/include/faad2/systems.h:273: error: redefinition of `gchar'
/usr/pkgsrc/audio/gtkpod/work/.buildlink/include/glib/glib-2.0/glib/gtypes.h:41: error: `gchar' previously declared here
/usr/pkgsrc/audio/gtkpod/work/.buildlink/include/faad2/systems.h:274: error: redefinition of `guchar'
/usr/pkgsrc/audio/gtkpod/work/.buildlink/include/glib/glib-2.0/glib/gtypes.h:47: error: `guchar' previously declared here
[snip]
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/audio/gtkpod
# 

If a package generates config.h by configure, the faad2/config.h
is not included.  It is defining HAVE_IN_PORT_T and HAVE_SOCKLEN_T.
If it is read, the top two errors do not happen.

And the faad2/systems.h has definitions of glib's types (gchar,
etc.).  These definitions exist in ifdef HAVE_GLIB_H.  But I can't
find definition of HAVE_GLIB_H anywhere.

best regards.
--
 Kouichirou Hiratsuka
   hira@po6.nsk.ne.jp