Subject: Re: pkg/30029
To: None <jmmv@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org>
From: Idar Tollefsen <idart@performancedesign.no>
List: pkgsrc-bugs
Date: 09/26/2005 11:07:02
The following reply was made to PR pkg/30029; it has been noted by GNATS.
From: Idar Tollefsen <idart@performancedesign.no>
To: jmmv@netbsd.org
Cc: pkgsrc-bugs@netbsd.org, gnats-bugs@NetBSD.org
Subject: Re: pkg/30029
Date: Mon, 26 Sep 2005 12:33:10 +0200
This is a multi-part message in MIME format.
--------------010701070504040305070902
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
> Could you please try replacing all instances of CONFIGURE_ENV to
> CONFIGURE_ARGS? I guess something wired is going on with your
> shell... Thank you.
I'm having the same problem on Solaris 10, but I just realized how stupidly
simple this is.
devel/glib2/Makefile doesn't include bsd.prefs.mk before adding to CPPFLAGS.
When bsd.prefs.mk is eventually included, it overwrites CPPFLAGS because I have
CPPFLAGS=, not CPPFLAGS+=, in my mk.conf.
Here's a new patch that fixes this. It's the same problem with pkg/30081
(x11/gtk2) and I've tested the same fix for it. I suspect it's the same with
pkg/30030 (databases/shared-mime-info) as well.
--------------010701070504040305070902
Content-Type: text/plain;
name="Makefile.diff.glib2"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="Makefile.diff.glib2"
--- Makefile.orig Thu Sep 22 12:34:50 2005
+++ Makefile Mon Sep 26 11:00:29 2005
@@ -47,12 +47,12 @@
CONFIGURE_ENV+= PERL_PATH=${PERL5}
-CPPFLAGS+= -DPREFIX="\"${PREFIX}\""
-CPPFLAGS+= -DPKGLOCALEDIR="\"${PKGLOCALEDIR}\""
-CPPFLAGS+= -DPKG_SYSCONFDIR="\"${PKG_SYSCONFDIR}\""
-
.include "../../mk/bsd.prefs.mk"
+CPPFLAGS+= -DPREFIX=\"${PREFIX}\"
+CPPFLAGS+= -DPKGLOCALEDIR=\"${PKGLOCALEDIR}\"
+CPPFLAGS+= -DPKG_SYSCONFDIR=\"${PKG_SYSCONFDIR}\"
+
.if ${OPSYS} == "FreeBSD"
SUBST_CLASSES= thr
--------------010701070504040305070902--