Subject: Re: pkg/31263: mplayer package probably should not use subdir in distfiles
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: Thomas Klausner <wiz@NetBSD.org>
List: pkgsrc-bugs
Date: 09/09/2005 10:11:02
The following reply was made to PR pkg/31263; it has been noted by GNATS.

From: Thomas Klausner <wiz@NetBSD.org>
To: cjs@cynic.net
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/31263: mplayer package probably should not use subdir in distfiles
Date: Fri, 9 Sep 2005 12:10:42 +0200

 On Fri, Sep 09, 2005 at 07:57:53AM +0000, cjs@cynic.net wrote:
 > >Number:         31263
 > >Category:       pkg
 > >Synopsis:       mplayer package probably should not use subdir in distfiles
 ...
 >     The mplayer package downloads its distribution files to a subdirectory
 >     under distfiles named for the version of mplayer. This means that you
 >     get a new, empty subdirectory for every new version, which is fine for
 >     the new version of mplayer itself. However, many versions of mplayer
 >     share the same font files (font-arial-iso-8859-1.tar.bz2 and a couple
 >     of others), but because the font files are also put in the separate
 >     subdirectory named for the mplayer version, the pkgsrc system will
 >     download again identical copies of the font files when making a new
 >     version of mplayer.
 ...
 >     Move the three font files up out of the subdirectory so that all
 >     versions of mplayer can share them (and any other programs that use
 >     those font files as well, for that matter). Given then that the
 >     only file left in the subdirectory is the mplayer distribution file
 >     itself, that might as well be moved up as well, and the subdirectory
 >     abandoned.
 
 The problem here is that pkgsrc only supports setting one directory
 for the distfiles per package, so you can't have distfiles in more
 than one directory locally.
 
 In the past, it happened more than once that the mplayer distfile
 changed its contents without changing its name -- and in this case
 we have to set DIST_SUBDIR. We can probably remove the setting
 currently, but as the package structure is now, we'll probably have
 to add it again in the future.
 
 One real solution would be to make a separate package for the font
 files, and let mplayer-share depend on it. Perhaps you want to work
 on that?
 
 Cheers,
  Thomas