>Number:         31185
>Category:       pkg
>Synopsis:       fix chat/silc-client nickname handling
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 07 20:58:00 +0000 2005
>Originator:     António Marques
>Release:        NetBSD 3.99.8
>Organization:
>Environment:
>Description:
silc fails to start silently if real_name="" in silc.conf, this is not the case with version 1.0.1 of this package which lacks UTF-8 nickname support. patch is from openbsd.

>How-To-Repeat:
run silc
>Fix:
patch-ad is included at the bottom

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/chat/silc-client/Makefile,v
retrieving revision 1.39
diff -u -r1.39 Makefile
--- Makefile    22 May 2005 20:07:43 -0000      1.39
+++ Makefile    7 Sep 2005 20:53:16 -0000
@@ -2,6 +2,7 @@
 #
 
 DISTNAME=              ${SILC_CLIENT_DISTNAME}
+PKGREVISION=           1
 CATEGORIES=            chat security
 MASTER_SITES=          http://www.silcnet.org/download/client/sources/ \
                        ftp://ftp.silcnet.org/silc/client/sources/ \
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/chat/silc-client/distinfo,v
retrieving revision 1.29
diff -u -r1.29 distinfo
--- distinfo    8 Apr 2005 15:12:48 -0000       1.29
+++ distinfo    7 Sep 2005 20:53:16 -0000
@@ -6,3 +6,4 @@
 SHA1 (patch-aa) = b9ae5da26840b193d3c9484c975af89294fa8049
 SHA1 (patch-ab) = fffda0e4c9a9227c1eb8d8646a02ce9ec5cdefef
 SHA1 (patch-ac) = f319907521b5d1caecfa47ac6e6239979370ea52
+SHA1 (patch-ad) = 0f27e863e843204023ec61e3b4a5492c63c2586b



$NetBSD$

--- lib/silcclient/client.c.orig        Thu Mar 31 01:07:10 2005
+++ lib/silcclient/client.c     Thu Jul 28 15:23:55 2005
@@ -137,7 +137,7 @@ bool silc_client_init(SilcClient client)
     SILC_LOG_ERROR(("Malformed hostname '%s'", client->hostname));
     return FALSE;
   }
-  if (!silc_utf8_valid(client->realname, strlen(client->realname))) {
+  if ((*client->realname != '\0') && (!silc_utf8_valid(client->realname, strlen(client->realname)))) {
     SILC_LOG_ERROR(("Malformed realname '%s'", client->realname));
     return FALSE;
   }