Re: pkg/31092: Python-2.3.5 Solaris

[grant beattie <grant%NetBSD.org@localhost>]

The following reply was made to PR pkg/31092; it has been noted by GNATS.

From: grant beattie <grant%NetBSD.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
        pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/31092: Python-2.3.5 Solaris
Date: Thu, 1 Sep 2005 10:06:30 +1000

 On Wed, Aug 31, 2005 at 01:37:02PM +0000, Gilles Dauphin wrote:
 
 >  You are true :) Solaris and gcc specific.
 >  The patch may be :
 >  
 >  +.if ${OPSYS} == "SunOS" && ${CC} == "gcc" 
 >  +#workaround for bug with Solaris/gcc : __builtin_huge_val is a func. in 
 > that 
 >  case, but  not declare as in Solaris header.
 >  +CONFIGURE_ARGS+=       OPT="${CFLAGS} 
 > -D\"Py_HUGE_VAL=__builtin_huge_val()\""
 >  +.else
 >   CONFIGURE_ARGS+=       OPT="${CFLAGS}"
 >  +.endif
 >  
 >  
 >  Is my fix valid ?
 
 yes, something like that. for brevity it can be written as:
 
 .include "../../mk/compiler.mk"
 
 .if !empty(CC_VERSION:Mgcc*)
 CFLAGS.SunOS+=         -D\"Py_HUGE_VAL=__builtin_huge_val()\"
 .endif