pkg/31084: netpbm-10.29 fails build on darwin

[scole%sdf.lonestar.org@localhost]

>Number:         31084
>Category:       pkg
>Synopsis:       netpbm-10.29 fails build on darwin
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Aug 28 18:10:00 +0000 2005
>Originator:     scole
>Release:        mac os x 7.9.0
>Organization:
>Environment:
Darwin goofy 7.9.0 Darwin Kernel Version 7.9.0: Wed Mar 30 20:11:17 PST 2005; 
root:xnu/xnu-517.12.7.obj~1/RELEASE_PPC  Power Macintosh powerpc
>Description:
netpbm-10.29 fails to build on darwin:

...
usr/bin/gnumake -C cameratopam/ -f 
/Volumes/NetBSD/pkgsrc/graphics/netpbm/work/netpbm-10.29/converter/other/cameratopam/Makefile
 \
    SRCDIR=/Volumes/NetBSD/pkgsrc/graphics/netpbm/work/netpbm-10.29 
BUILDDIR=/Volumes/NetBSD/pkgsrc/graphics/netpbm/work/netpbm-10.29 all 
gcc -pipe -c 
-I/Volumes/NetBSD/pkgsrc/graphics/netpbm/work/netpbm-10.29/converter/other/cameratopam
 -I.  -DNDEBUG \
    -no-cpp-precomp -I/Volumes/NetBSD/pkg/include -O2 -DBIND_8_COMPAT 
-DHAVE_RESOLV_H -I/Volumes/NetBSD/pkg/include   -o camera.o camera.c
In file included from camera.c:7:
/usr/include/netinet/in.h:255: error: parse error before "in_addr_t"
/usr/include/netinet/in.h:312: error: parse error before "u_char"
/usr/include/netinet/in.h:314: error: parse error before "sin_port"
/usr/include/netinet/in.h:317: error: parse error before '}' token
/usr/include/netinet/in.h:329: error: field `ip_dst' has incomplete type
/usr/include/netinet/in.h:398: error: field `imr_multiaddr' has incomplete type
/usr/include/netinet/in.h:399: error: field `imr_interface' has incomplete type
/usr/include/netinet/in.h:315: error: storage size of `sin_addr' isn't known
gnumake[3]: *** [camera.o] Error 1
gnumake[2]: *** [cameratopam/all] Error 2
gnumake[1]: *** [other/all] Error 2
gnumake: *** [converter/all] Error 2
*** Error code 2

Stop.
bmake: stopped in /Volumes/NetBSD/pkgsrc/graphics/netpbm

>How-To-Repeat:
cd .../pkgsrc/graphics/netpbm && sudo bmake
>Fix:

I believe there are 2 problems

1) sind_addr isn't known in
./work/netpbm-10.29/converter/other/cameratopam/camera.c

to fix,  add '#include <sys/types.h>' to the file if on darwin.

2) a namespace collision with local variable named INFINITY in
./work/netpbm-10.29/editor/pnmaddnoise.c, in a few subroutines.
My fix was to rename INFINITY to nINFINITY.