Re: pkg/30920: audio/mpg321 is missing a dependency on audio/libao-oss

[Rui-Xiang Guo <rxg%myrealbox.com@localhost>]

On Fri, Aug 12, 2005 at 04:35:04PM +0000, Chuck Cranor wrote:
> The following reply was made to PR pkg/30920; it has been noted by GNATS.
> 
> From: Chuck Cranor <chuck%ece.cmu.edu@localhost>
> To: Thomas Klausner <wiz%NetBSD.org@localhost>
> Cc: gnats-bugs%NetBSD.org@localhost
> Subject: Re: pkg/30920: audio/mpg321 is missing a dependency on 
> audio/libao-oss
> Date: Fri, 12 Aug 2005 12:34:42 -0400
> 
>  > 
>  > On Fri, Aug 05, 2005 at 02:28:00PM +0000, Chuck Cranor wrote:
>  > >  add dependency on audio/libao-oss
>  > 
>  > No -- on NetBSD, you should better install audio/libao-sun.
>  > Since it depends on the platform which you want and you even
>  > have the choice on some platforms, the packages are not installed
>  > automatically.
>  > 
>  > I thought libao had a MESSAGE about this, but it seems it doesn't :(
>  
>  
>  hi-
>  
>      so the high-level issue that concerns me is that we used to
>  have an 'auto/mpg321' package that worked fine out of the box,
>  and now mpg321 no longer works out of the box.
>  
>      speaking as a user, all i care about is the mpg321 application
>  working when i install it...  I don't care about libao or what options 
>  it installs, as long as my appliations work by default i am happy.
>  
>      even if there was a MESSAGE (that would scroll unread off my 
>  screen), the current config asks us lazy pkgsrc users to think too 
>  much rather than providing a reasonable default working mpg321 
>  application.

Hi,
please try this patch -
RCS file: /cvsroot/pkgsrc/audio/mpg321/Makefile,v
retrieving revision 1.9
diff -b -u -r1.9 Makefile
--- Makefile    11 Apr 2005 21:44:55 -0000      1.9
+++ Makefile    19 Aug 2005 04:51:57 -0000
@@ -12,6 +12,8 @@
 GNU_CONFIGURE=         yes
 CONFIGURE_ARGS+=       --disable-mpg123-symlink
 
+.include "options.mk"
+
 .include "../../audio/libao/buildlink3.mk"
 .include "../../audio/libid3tag/buildlink3.mk"
 .include "../../audio/libmad/buildlink3.mk"

and added the attached 'options.mk' into audio/mpg321,
I think it fit your needs.
In fact, this problem also happen with chat/gaim, maybe also other pkgs.

-rxg

# $NetBSD$

PKG_OPTIONS_VAR=        PKG_OPTIONS.mpg321
PKG_SUPPORTED_OPTIONS=  libao-arts libao-esound libao-macosx libao-oss libao-sun

.include "../../mk/bsd.prefs.mk"

.if ${OPSYS} == "NetBSD" || ${OPSYS} == "SunOS"
PKG_SUGGESTED_OPTIONS+= libao-sun
CONFIGURE_ARGS+=        --with-default-audio=sun
.endif

.if ${OPSYS} == "FreeBSD" || ${OPSYS} == "Linux"
PKG_SUGGESTED_OPTIONS+= libao-oss
CONFIGURE_ARGS+=        --with-default-audio=oss
.endif

.include "../../mk/bsd.options.mk"

.if !empty(PKG_OPTIONS:Mlibao-arts)
DEPENDS+=               libao-arts>=0.8.6:../../audio/libao-arts
.endif

.if !empty(PKG_OPTIONS:Mlibao-esound)
DEPENDS+=               libao-esound>=0.8.6:../../audio/libao-esound
.endif

.if !empty(PKG_OPTIONS:Mlibao-macosx)
DEPENDS+=               libao-macosx>=0.8.6:../../audio/libao-macosx
.endif

.if !empty(PKG_OPTIONS:Mlibao-oss)
DEPENDS+=               libao-oss>=0.8.6:../../audio/libao-oss
.endif

.if !empty(PKG_OPTIONS:Mlibao-sun)
DEPENDS+=               libao-sun>=0.8.6:../../audio/libao-sun
.endif