pkg/30912: archivers/zip zip-2.3nb3 solaris x86 gcc

["Gilles Dauphin" <dauphin%enst.fr@localhost>]

>Number:         30912
>Category:       pkg
>Synopsis:       archivers/zip zip-2.3nb3 solaris x86 gcc
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 04 13:29:00 +0000 2005
>Originator:     Gilles Dauphin
>Release:        SunOS 5.10 i86pc
>Organization:
ENST 
>Environment:


System: SunOS bi.enst.fr 5.10 Generic i86pc


>Description:


archivers/zip don't compile on solaris x86 gcc

2005/07/21 14:40:12  67/5500= 1.2% archivers/zip @ i386> gcc -c -O2 -I. -DUNIX 
-O -DASMV -DASM_CRC -DNO_STRC
HR -DNO_STRRCHR -DNO_STDLIB_H -DNO_STDDEF_H -DNO_UNISTD_H -DNO_FCNTL_H 
-DNO_STRING_H -DHAVE_SGTTY_H ttyio.c
2005/07/21 14:40:12  67/5500= 1.2% archivers/zip @ i386> ttyio.c: In function 
`Echoff':
2005/07/21 14:40:12  67/5500= 1.2% archivers/zip @ i386> ttyio.c:275: error: 
`ECHO' undeclared (first use in
 this function)
2005/07/21 14:40:12  67/5500= 1.2% archivers/zip @ i386> ttyio.c:275: error: 
(Each undeclared identifier is 
reported only once
2005/07/21 14:40:12  67/5500= 1.2% archivers/zip @ i386> ttyio.c:275: error: 
for each function it appears in
.)
2005/07/21 14:40:12  67/5500= 1.2% archivers/zip @ i386> ttyio.c: In function 
`Echon':
2005/07/21 14:40:12  67/5500= 1.2% archivers/zip @ i386> ttyio.c:289: error: 
`ECHO' undeclared (first use in
 this function)
2005/07/21 14:40:12  67/5500= 1.2% archivers/zip @ i386> *** Error code 1
2005/07/21 14:40:12  67/5500= 1.2% archivers/zip @ i386> 
2005/07/21 14:40:12  67/5500= 1.2% archivers/zip @ i386> Stop.
2005/07/21 14:40:12  67/5500= 1.2% archivers/zip @ i386> bmake: stopped in 
/usr/pkgsrc/archivers/zip/work/zi
p-2.3
2005/07/21 14:40:12  67/5500= 1.2% archivers/zip @ i386> *** Error code 1
2005/07/21 14:40:12  67/5500= 1.2% archivers/zip @ i386> 
2005/07/21 14:40:12  67/5500= 1.2% archivers/zip @ i386> Stop.
2005/07/21 14:40:12  67/5500= 1.2% archivers/zip @ i386> bmake: stopped in 
/usr/pkgsrc/archivers/zip/work/zi
p-2.3



>How-To-Repeat:


bmake 


>Fix:


when Building for zip-2.3nb3 pkgsrc do the following things:
/usr/pkg/bin/bmake -f unix/Makefile generic CC=gcc CPP="gcc -E"
but in unix/configure it is overwirted by /lib/cpp.
do not overwrite CPP in configure , if defined.

suggest patch is here:
-------------------------------------------------
<root@u2: 844> pwd
/usr/pkgsrc/archivers/zip
<root@u2: 845> cat patches/patch-aa
--- unix/configure.orig Tue Apr 27 21:49:05 1999
+++ unix/configure      Thu Aug  4 15:07:04 2005
@@ -13,19 +13,21 @@
 
 CC=${1-cc}
 CFLAGS=${2-"-O2 -I. -DUNIX"}
-LFLAGS1="-s"
+LFLAGS1=""
 LN="ln -s"
 
 echo Check for the C preprocessor
 # on SVR4, cc -E does not produce correct assembler files. Need /lib/cpp.
-CPP="${CC} -E"
+if [ "$CPP" = "" ] ; then
+  CPP="${CC} -E"
 # solaris as(1) needs -P, maybe others as well ?
-[ -f /usr/ccs/lib/cpp ] && CPP="/usr/ccs/lib/cpp -P"
-[ -f /usr/lib/cpp ] && CPP=/usr/lib/cpp
-[ -f /lib/cpp ] && CPP=/lib/cpp
-[ -f /usr/bin/cpp ] && CPP=/usr/bin/cpp
-[ -f /xenix ] && CPP="${CC} -E"
-[ -f /lynx.os ] && CPP="${CC} -E"
+  [ -f /usr/ccs/lib/cpp ] && CPP="/usr/ccs/lib/cpp -P"
+  [ -f /usr/lib/cpp ] && CPP=/usr/lib/cpp
+  [ -f /lib/cpp ] && CPP=/lib/cpp
+  [ -f /usr/bin/cpp ] && CPP=/usr/bin/cpp
+  [ -f /xenix ] && CPP="${CC} -E"
+  [ -f /lynx.os ] && CPP="${CC} -E"
+fi
 
 echo Check if we can use asm code
 OBJA=""