Subject: pkg/30715: Make openslp an option for Netatalk package(s)
To: None <,,>
From: Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
List: pkgsrc-bugs
Date: 07/10/2005 18:58:01
>Number:         30715
>Category:       pkg
>Synopsis:       Make openslp an option for Netatalk package(s)
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 10 18:58:00 +0000 2005
>Originator:     Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
>Release:        NetBSD 3.0_BETA
Falling Raindrops
System: NetBSD 3.0_BETA NetBSD 3.0_BETA (PIZZA) #8: Sun Jul 10 00:16:52 CEST 2005 hf@heiligenberg:/var/obj/netbsd-builds/3_0/sparc/sys/arch/sparc/compile/PIZZA sparc
Architecture: sparc
Machine: sparc

The net/netatalk package depends on net/openslp unconditionally. From
the Netatalk documentation:

  * OpenSLP
    SLP (Service Location Protocol) is an IETF standards track protocol that
    provides a framework to allow networking applications to discover the
    existence, location, and configuration of networked services in enterprise
    Mac OS X uses it to locate AFP servers, even though newer version prefer

In other words, slp is irrelevant for Macintosh System 6..9 clients,
and for MacOS X 10.3..4 clients -- enough reasons to make the
dependency on openslp an option.


Build and install Netatalk 2.x package, find it installs
openslp. Observe that none of the clients you run actually makes use
of slp. Further, observe that openslp has the occasional security


Apply the following patch:

Index: Makefile
RCS file: /cvsroot/pkgsrc/net/netatalk/Makefile,v
retrieving revision 1.42
diff -u -u -r1.42 Makefile
--- Makefile	26 May 2005 05:47:40 -0000	1.42
+++ Makefile	10 Jul 2005 18:39:02 -0000
@@ -58,7 +58,7 @@
 SUBST_SED.paths+=	-e "s,\(NETBSD.*\)/etc/rc.d,\1${PREFIX}/${RCD_SCRIPTS_EXAMPLEDIR},"
-PKG_SUPPORTED_OPTIONS=  cups kerberos
+PKG_SUPPORTED_OPTIONS=  cups slp kerberos
 .include "../../mk/"
@@ -69,6 +69,13 @@
 CONFIGURE_ARGS+=        --disable-cups
+.if !empty(PKG_OPTIONS:Mslp)
+.include "../../net/openslp/"
+CONFIGURE_ARGS+=        --enable-srvloc
+CONFIGURE_ARGS+=        --disable-srvloc
 .if !empty(PKG_OPTIONS:Mkerberos)
 .include "../../mk/"
 CONFIGURE_ARGS+=	--with-gssapi --enable-krbV-uam
@@ -83,7 +90,6 @@
 	${INSTALL_DATA_DIR} ${PREFIX}/libexec/psffilters
 .include "../../databases/db4/"
-.include "../../net/openslp/"
 .include "../../security/openssl/"
 .include "../../security/tcp_wrappers/"