Re: pkg/30663: [patch] lang/sbcl - ASDF-INSTALL is broken out of the box

[Quentin Garnier <cube%cubidou.net@localhost>]

The following reply was made to PR pkg/30663; it has been noted by GNATS.

From: Quentin Garnier <cube%cubidou.net@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/30663: [patch] lang/sbcl - ASDF-INSTALL is broken out of the 
box
Date: Tue, 5 Jul 2005 09:46:39 +0200

 --yUmmepPgoWmUqRhm
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Mon, Jul 04, 2005 at 09:03:00PM +0000, Peter Schuller wrote:
 > >Number:         30663
 > >Category:       pkg
 > >Synopsis:       ASDF-INSTALL is broken out-of-the box as installed by pk=
 gsrc
 [...]
 > Index: Makefile
 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 > RCS file: /cvsroot/pkgsrc/lang/sbcl/Makefile,v
 > retrieving revision 1.1.1.1
 > diff -u -r1.1.1.1 Makefile
 > --- Makefile 23 Jun 2005 03:00:20 -0000      1.1.1.1
 > +++ Makefile 4 Jul 2005 20:54:52 -0000
 > @@ -41,6 +41,8 @@
 >  PKG_SKIP_REASON=3D  "Sorry, need a Common Lisp system"
 >  .endif
 > =20
 > +DEPENDS+=3D               gtar-base-1.15.1:../../archivers/gtar-base
 > +
 >  post-patch:
 >      ${MV} ${WRKSRC}/install.sh ${WRKSRC}/install.sh.dist
 >      ${SED} -e "s,@PREFIX@,${PREFIX}," ${WRKSRC}/install.sh.dist > ${WRKSRC}=
 /install.sh
 [...]
 > Index: patches/patch-ad
 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 > RCS file: patches/patch-ad
 > diff -N patches/patch-ad
 > --- /dev/null        1 Jan 1970 00:00:00 -0000
 > +++ patches/patch-ad 4 Jul 2005 20:54:52 -0000
 > @@ -0,0 +1,15 @@
 > +$NetBSD$
 > +
 > +--- contrib/asdf-install/installer.lisp.orig        2005-07-04 
 > 20:49:42.0000000=
 00 +0200
 > ++++ contrib/asdf-install/installer.lisp
 > +@@ -249,8 +249,9 @@
 > +   (let* ((tar
 > +      (with-output-to-string (o)
 > +        (or
 > +-        (sb-ext:run-program #-darwin "tar"
 > ++        (sb-ext:run-program #-(or darwin netbsd)"tar"
 > +                             #+darwin "gnutar"
 > ++                            #+netbsd "gtar"
 > +                             (list "-C" (namestring source)
 > +                                   "-xzvf" (namestring packagename))
 > +                             :output o
 
 The patch is not correct.  The Makefile should add "gtar" to USE_TOOLS,
 and then the program run by installer.lisp should unconditionally be
 replaced by ${GTAR}.
 
 Also, is it a run dependency or a build depedency (I obviously don't
 know anything about sbcl, that's why I'm leaving jonb to actually
 handle the PR)?  The PR made me think the former, but the name of the
 affected file (install.lisp) hints for the latter.
 
 --=20
 Quentin Garnier - cube%cubidou.net@localhost - cube%NetBSD.org@localhost
 "When I find the controls, I'll go where I like, I'll know where I want
 to be, but maybe for now I'll stay right here on a silent sea."
 KT Tunstall, Silent Sea, Eye to the Telescope, 2004.
 
 --yUmmepPgoWmUqRhm
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.6 (NetBSD)
 
 iQEVAwUBQso639goQloHrPnoAQKeeAf7BNnQrr3Gu4QcC28mjRFmlE+xnxnOQDfK
 4yhUaCo9SPZji8z5B+SMOA6jZhwRkt/Xeq27fQeEvX1tTPYFcb4QPNMgNltDWFzt
 GXTj47gt0lsITX+CAMVSMUein2RgMYoE6NRnzSAhDhY0FdhXtmQa9hfg8biKiA9/
 QtjzLl67MFSoFadvwVtjTcUsT/czJ3svnIbNW0qykSQddAtdneKvdvOB+2R5NpcP
 8PlNXdxEN2CjR/IoCtj5ZfCaKc2voanLp3tRQ3E3jk43DJXGOX9qr0dmeB6ZhgYq
 ucVJyhfFZM9ryxhYpUQM4aLnmDrqf1Gnar/a7Noar+eZaVQNA6PZsA==
 =e9qt
 -----END PGP SIGNATURE-----
 
 --yUmmepPgoWmUqRhm--