Re: pkg/28564 devel/eclipse: does not start, a patch

[Antoine Reilles <Antoine.Reilles%loria.fr@localhost>]

The following reply was made to PR pkg/28564; it has been noted by GNATS.

From: Antoine Reilles <Antoine.Reilles%loria.fr@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/28564 devel/eclipse: does not start, a patch
Date: Fri, 3 Jun 2005 13:42:15 +0200

 --AqsLC8rIMeq19msA
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Here the patch i used to get eclipse working ond -current.
 
 I did not understand the reason of what the files/eclipse script do with -data
 and -config, the default behavior when launching eclipse looks much better (it
 starts by proposing a default workspace (${HOME}/workspace), and it is possible
 to tell eclipse to start in you prefered workspace by default. The script
 disables this feature.
 
 I feel it whould be better to let the files/eclipse script just be:
 
 #!/bin/sh
 #
 # $NetBSD: eclipse,v 1.2 2005/01/19 20:44:11 jschauma Exp $
 #
 # start the eclipse IDE
 
 ECLIPSE_DIR=/usr/pkg/eclipse
 
 ${ECLIPSE_DIR}/eclipse $@
 
 or maybe use the alternative framework for it (well, looks useless, but who 
knows...)
 
 regards,
 antoine
 
 --AqsLC8rIMeq19msA
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="eclipse.diff"
 
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/devel/eclipse/Makefile,v
 retrieving revision 1.13
 diff -u -r1.13 Makefile
 --- Makefile   19 Jan 2005 20:44:11 -0000      1.13
 +++ Makefile   3 Jun 2005 11:39:25 -0000
 @@ -38,6 +38,7 @@
  do-build:
        cd ${WRKDIR} && ${MAKE_ENV} ${SH} build -os linux -ws motif -arch x86
  .else
 +BUILD_DEPENDS+=       suse_openmotif>=9.1:../../emulators/suse_openmotif
  NO_BUILD=     #defined
  PAXDIR=               ${WRKSRC}
  CHECK_SHLIBS= NO
 Index: files/eclipse
 ===================================================================
 RCS file: /cvsroot/pkgsrc/devel/eclipse/files/eclipse,v
 retrieving revision 1.2
 diff -u -r1.2 eclipse
 --- files/eclipse      19 Jan 2005 20:44:11 -0000      1.2
 +++ files/eclipse      3 Jun 2005 11:39:25 -0000
 @@ -14,4 +14,4 @@
  data=${data:-${HOME}}
  configuration=${configuration:-${HOME}/.eclipse}
  
 -(cd ${ECLIPSE_DIR} && ./eclipse -data ${data} -configuration ${configuration} 
$@)
 +${ECLIPSE_DIR}/eclipse -data ${data} -configuration ${configuration} $@
 
 --AqsLC8rIMeq19msA--