pkg/30032: problem building fluxbox on -current

[reilles%loria.fr@localhost]

>Number:         30032
>Category:       pkg
>Synopsis:       compile fluxbox on -current (and a patch)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 22 11:59:00 +0000 2005
>Originator:     Antoine Reilles
>Release:        NetBSD 3.99.3
>Organization:
        
>Environment:
        
        
System: NetBSD arcelot.loria.fr 3.99.3 NetBSD 3.99.3 (XEN0) #0: Tue Apr 12 
14:45:09 CEST 2005 
tonio%arcelot.loria.fr@localhost:/usr/obj/sys/arch/i386/compile/XEN0 i386
Architecture: i386
Machine: i386
>Description:
Fluxbox has problems compiling on -current
The first problem is that the workaround for pkg/29825 is not applied with 
-current
I disabled the test since it is not really a problem to build only with -O1 on
any machine (thanks dynek)

After that, there is a problem with libiconv. Adding 
.include "../../converters/libiconv/buildlink3.mk"
fixed that.

>How-To-Repeat:
try to compile wm/fluxbox on -current
>Fix:
A possible solution

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/wm/fluxbox/Makefile,v
retrieving revision 1.22
diff -u -r1.22 Makefile
--- Makefile    11 Apr 2005 21:47:47 -0000      1.22
+++ Makefile    22 Apr 2005 11:52:21 -0000
@@ -22,13 +22,14 @@
 
 # Workaround for pkg/29825 -- older compilers apparently
 # have problems building this package.
-.if (${MACHINE_PLATFORM:MNetBSD-2.0*-*} != "")
+#.if (${MACHINE_PLATFORM:MNetBSD-2.0*-*} != "")
 BUILDLINK_TRANSFORM+=  rename:-O2:-O1
-.endif
+#.endif
 
 CONFIGURE_ARGS+=       --enable-nls
 CONFIGURE_ARGS+=       --enable-xinerama
 
 .include "options.mk"
 
+.include "../../converters/libiconv/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"

>Unformatted: