>Number:         29796
>Category:       pkg
>Synopsis:       minor pkglint fix
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Mar 26 16:41:00 +0000 2005
>Originator:     Lex Wennmacher
>Release:        NetBSD 1.6.1
>Organization:
Wennmacher
>Environment:
	
	
System: NetBSD mail.wennmacher.org 1.6.1 NetBSD 1.6.1 (MAIL) #0: Sun Jul 13 22:22:21 MEST 2003 wennmach@mail.wennmacher.org:/usr/src/sys/arch/i386/compile/MAIL i386
Architecture: i386
Machine: i386
>Description:
If pkglint detects an RCS-Id in a patch, it warns to use the "-ko" flag
on cvs commit. But "-ko" is an option for "cvs import" and "cvs add",
not for "cvs commit"
>How-To-Repeat:
	
>Fix:
Index: pkglint.pl
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/pkglint/files/pkglint.pl,v
retrieving revision 1.135
diff -u -r1.135 pkglint.pl
--- pkglint.pl	24 Feb 2005 22:50:44 -0000	1.135
+++ pkglint.pl	26 Mar 2005 16:29:45 -0000
@@ -1039,7 +1039,7 @@
 
 	foreach my $line (@$lines[1..scalar(@$lines)-1]) {
 		if ($opt_committer && $line->text =~ /$regex_known_rcs_tag/) {
-			log_warning($line->file, $line->lineno, "Possible RCS tag \"\$$1\$\". Use binary mode (-ko) on commit/import.");
+			log_warning($line->file, $line->lineno, "Possible RCS tag \"\$$1\$\". Use binary mode (-ko) on cvs add/import.");
 		}
 	}
 

>Unformatted: