Subject: Re: pkg/25338
To: None <bad@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org>
From: Christoph Badura <bad@bsd.de>
List: pkgsrc-bugs
Date: 03/23/2005 22:07:02
The following reply was made to PR pkg/25338; it has been noted by GNATS.
From: Christoph Badura <bad@bsd.de>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/25338
Date: Wed, 23 Mar 2005 23:05:45 +0100
Note, the change to require and link against glib has been backed out in
revision 1.18 of pkgsrc/games/gnugo/Makefile.
As far as I can tell, glib is not necessary to compile gnugo.
glib is apparently optionally wanted on platform that don't provide
a vsnprintf()-like function.
Looking at the code none of the invocation appear to be prone to buffer
overflows and the specific coding style used makes it clear that the
authors were doing cargo cult programming.
This should stay backed out for now.
--chris