On Thu, Jan 06, 2005 at 08:48:00PM +0000, georg.schwarz%freenet.de@localhost wrote: > >Number: 28889 > >Category: pkg > >Synopsis: bug in graphics/gdk-pixbuf > >Confidential: no > >Severity: non-critical > >Priority: low > >Responsible: pkg-manager > >State: open > >Class: sw-bug > >Submitter-Id: net > >Arrival-Date: Thu Jan 06 20:48:00 +0000 2005 > >Originator: Georg Schwarz > >Release: current pkgsrc > >Organization: > >Environment: > IRIX lorenz 5.3 08031225 IP20 mips > >Description: > Since gdk-pixbuf 0.22 seems to be unmaintained by the Gnome project, maybe > pkgsrc can look into and fix, if necessary, the following issue: > http://bugzilla.gnome.org/show_bug.cgi?id=156186 > > In gdk-pixbuf io-gif.c line 620 reads > if (w > 0 && h > 0) > ShouldnŽt that be rather > if (*w > 0 && *h > 0) > > On my system at least I have to modify io-gif.c in order for compiling not to > fail. It's obviously an error, as comparing pointers to 0 don't make much sense, and we already know they're not NULL since the previous chunk of code assumes they aren't. I don't think it would harm to change to the obvious intended behaviour. However, it might break things for some unknown reason. Meanwhile, I think it's safe to commit the fix, and we can always failback to a simple avoidance of the test, as it always true. How does it fail to compile, by the way? -- Quentin Garnier - cube%cubidou.net@localhost - cube%NetBSD.org@localhost "Commala-come-five! / Even when the shadows rise! To see the world and walk the world / Makes ya glad to be alive." Susannah's Song, The Dark Tower VI, Stephen King, 2004.
Attachment:
pgpxvXS8FPu4j.pgp
Description: PGP signature