--WplhKdTI2c8ulnbP
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 06, 2005 at 08:48:00PM +0000, georg.schwarz@freenet.de wrote:
> >Number:         28889
> >Category:       pkg
> >Synopsis:       bug in graphics/gdk-pixbuf
> >Confidential:   no
> >Severity:       non-critical
> >Priority:       low
> >Responsible:    pkg-manager
> >State:          open
> >Class:          sw-bug
> >Submitter-Id:   net
> >Arrival-Date:   Thu Jan 06 20:48:00 +0000 2005
> >Originator:     Georg Schwarz
> >Release:        current pkgsrc
> >Organization:
> >Environment:
> IRIX lorenz 5.3 08031225 IP20 mips
> >Description:
> Since gdk-pixbuf 0.22 seems to be unmaintained by the Gnome project, mayb=
e pkgsrc can look into and fix, if necessary, the following issue:
> http://bugzilla.gnome.org/show_bug.cgi?id=3D156186
>=20
> In gdk-pixbuf io-gif.c line 620 reads
>   if (w > 0 && h > 0)
>   Shouldn=C5=BDt that be rather
>   if (*w > 0 && *h > 0)
>=20
> On my system at least I have to modify io-gif.c in order for compiling no=
t to fail.

It's obviously an error, as comparing pointers to 0 don't make much
sense, and we already know they're not NULL since the previous
chunk of code assumes they aren't.

I don't think it would harm to change to the obvious intended
behaviour.  However, it might break things for some unknown reason.
Meanwhile, I think it's safe to commit the fix, and we can always
failback to a simple avoidance of the test, as it always true.

How does it fail to compile, by the way?

--=20
Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
"Commala-come-five! / Even when the shadows rise!
To see the world and walk the world / Makes ya glad to be alive."
Susannah's Song, The Dark Tower VI, Stephen King, 2004.

--WplhKdTI2c8ulnbP
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iQEVAwUBQeMetdgoQloHrPnoAQJbZwf+PwGgnuZY9NKRsy9EMsqDkZSPqCyVXuZ1
sPWNKKxVkn7a7xO3eHer1pP5N0I1vUw6nxdnA4RS0XDA3EXX+cAEYQ404ee8nXaL
2Ay60Hw4aQZqN5PeL7eSYH2/soHFudlWdrf9bnOgsC/YpggNdV4tcEEUCUljCL5D
zoIRDiwpd7Wy2+z2EZgW4rB6BrbB2/+5+4JhIPfNMsgavFfHFpM+FJz6zcMlwczN
ekr346Dy8dgqdrEg/br42Xo75w2i+TvXFAQvPumvaOnxv3gGsyPTNZkesnVsX+CF
uTQa73BD1qtyX27QF0dVgTKdKXbGXoky6pi8PhtlSi4zMPKQKbcXoA==
=PUho
-----END PGP SIGNATURE-----

--WplhKdTI2c8ulnbP--