Subject: pkg/28831: clamav package's USE_MILTER option is undocumented
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: John F. Woods <jfw@jfwhome.funhouse.com>
List: pkgsrc-bugs
Date: 01/01/2005 19:18:01
>Number:         28831
>Category:       pkg
>Synopsis:       clamav package's USE_MILTER option is undocumented
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 01 19:18:01 +0000 2005
>Originator:     John F. Woods
>Release:        NetBSD 2.0
>Organization:
Misanthropes-R-Us
>Environment:
System: NetBSD jfwhome.funhouse.com 2.0 NetBSD 2.0 (JFW) #0: Sun Dec 12 11:35:56 EST 2004 jfw@jfwhome.funhouse.com:/usr/src/sys/arch/i386/compile/JFW i386
Architecture: i386
Machine: i386
>Description:
	I wanted to install the clamav antivirus package as a "milter" for
sendmail.
	The first issue would be that clamav's milter mode is disabled by
default, even though (at least as of netbsd 2.0) the stock sendmail is
compiled with milter capability enabled (at least /usr/lib/libmilter.*
exists).
	The second issue is that it was not at all obvious how to enable
the use of the milter capability.  I tried adding "--enable-milter" to the
CONFIGURE_ARGS lines in the package Makefile, but that didn't work.  Upon
discovering that config.log said that both --enable-milter and --disable-milter
had been given as arguments, I took a closer look at the package Makefile and
discovered the USE_MILTER variable.  There was no description of the variable
aside from how it was used in the Makefile, but fortunately I was able to
figure it out right away; someone who is not a developer would have had
much more difficulty doing so, and thus the USE_MILTER variable ought to
have been documented somewhere.  Or, if USE_MILTER is supposed to be
automatically set somehow, it obviously wasn't.
	If USE_MILTER is supposed to be a user-selectable option, there
should probably be some standard way for all packages to document their
user-selectable options, like perhaps an Options.txt text file in the
package directory, or at least a documented standard that the Makefile
should document those switches in the first few dozen lines somewhere.

>How-To-Repeat:
	
>Fix: