Subject: pkg/28818: mail/sma assumes presence of regex.h
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: None <georg.schwarz@freenet.de>
List: pkgsrc-bugs
Date: 12/30/2004 20:51:01
>Number:         28818
>Category:       pkg
>Synopsis:       mail/sma assumes presence of regex.h
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Dec 30 20:51:00 +0000 2004
>Originator:     Georg Schwarz
>Release:        current pkgsrc
>Organization:
>Environment:
IRIX lorenz 5.3 08031225 IP20 mips
>Description:
mail/sma is compiled with -DUSE_REGEXP, which is not appropriate for some systems.
>How-To-Repeat:

>Fix:
patch sma's Makefile as follows:

--- Makefile.orig       2004-12-30 21:38:25.000000000 +0100
+++ Makefile    2004-12-30 21:38:42.000000000 +0100
@@ -5,9 +5,9 @@
 BINDIR = /usr/local/bin
 MANDIR = /usr/local/man/man8
 
-CC     = gcc
+#CC    = gcc
 # XPG3 regular expressions (GNU/BSD/SVR4)
-CFLAGS = -Wall -O -DUSE_REGEXP
+#CFLAGS        = -Wall -O -DUSE_REGEXP
 # Others
 #CFLAGS        = -Wall -O

and change the pkgsrc Makefile as follows:

--- Makefile.orig       2004-12-30 21:39:25.000000000 +0100
+++ Makefile    2004-12-30 21:40:10.000000000 +0100
@@ -17,6 +17,10 @@
 
 .include "../../mk/bsd.prefs.mk"
 
+.if empty(LOWER_OPSYS:Mirix5*)
+CFLAGS+=       -DUSE_REGEXP
+.endif
+
 do-install:
        cd ${WRKSRC};                                           \
        ${INSTALL_PROGRAM} sma ${PREFIX}/bin;                   \

As an extra benefit, now the pkgsrc CFLAGS and CC definitions are used.