Subject: pkg/26443: Makefile for textproc/icu is broken
To: None <gnats-bugs@gnats.netbsd.org>
From: None <kre@munnari.OZ.AU>
List: pkgsrc-bugs
Date: 07/27/2004 15:44:05
>Number:         26443
>Category:       pkg
>Synopsis:       Makefile for textproc/icu is broken
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 27 09:19:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     Robert Elz
>Release:        NetBSD 1.6X    ( --- pkgsrc current as of date/time of this mail)
>Organization:
	Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 1.6X NetBSD 1.6X (JADE) #17: Wed Sep 24 20:25:35 ICT 2003 kre@jade.coe.psu.ac.th:/usr/src/real-sys/arch/i386/compile/JADE i386
Architecture: i386
Machine: i386
>Description:
	The Makefile for textproc/icu uses ${PKGVERSION} in the path to
	the distfile on the MASTER_SITE (which is correct), but fails
	to define PKGVERSION anywhere.   This causes the distfile fetch
	to fail (and consequently, the distfile isn't on ftp.netbsd.org
	so can't be fetched form the backup sites either).

>How-To-Repeat:
	rm ..../distfiles/icu-3.0.tgz
	cd ..../pkgsrc/textproc/icu
	make checksum     (or make fetch)

	Observe that no distfile is fetched.

>Fix:

	One way is to apply the appended patch.    Whether this complies
	with approved pkgsrc methodology or not, I'll leave for someone
	else to decide (it works, which is all that matters to me - actually,
	even that doesn't matter to me all that much, I just collect
	distfiles, I don't use all that many of them)

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/textproc/icu/Makefile,v
retrieving revision 1.33
diff -u -r1.33 Makefile
--- Makefile	26 Jun 2004 20:18:50 -0000	1.33
+++ Makefile	27 Jul 2004 08:38:12 -0000
@@ -1,7 +1,8 @@
 # $NetBSD: Makefile,v 1.33 2004/06/26 20:18:50 recht Exp $
 #
 
-DISTNAME=	icu-3.0
+PKGVERSION=	3.0
+DISTNAME=	icu-${PKGVERSION}
 CATEGORIES=	textproc
 #
 # The IBM site has long delays that can cause ftp to timeout.  Use the
>Release-Note:
>Audit-Trail:
>Unformatted: