Subject: pkg/26243: USE_MMX should be in BUILD_DEFS only on x86
To: None <>
From: None <>
List: pkgsrc-bugs
Date: 07/11/2004 07:23:58
>Number:         26243
>Category:       pkg
>Synopsis:       USE_MMX should be in BUILD_DEFS only on x86
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 11 09:49:00 UTC 2004
>Originator:     Georg Schwarz
>Release:        current pkgsrc
IRIX lorenz 5.3 08031225 IP20 mips
USE_MMX is only meaningful on x86 platforms and should thus only there be included in BUILD_DEFS (where used). So far the following file unconditionally add it to BUILD_DEFS:


x11/eterm/Makefile adds USE_MMX to BUILD_DEFS only when it is not "NO", which is also incorrect.

multimedia/avidemux/Makefile and multimedia/xawtv/Makefile seem to imply they compile on x86 only but do not explicitly say so.


Enclose BUILD_DEFS+= USE_MMX by  .if empty(USE_MMX:M[Yy][Ee][Ss]) ... .fi
in the affected Makefiles.
In case there packages work on x86 anyway, this should be denoted instead.