Subject: pkg/25786: ...pkgsrc/archivers/freeze: main() should return {int}.
To: None <gnats-bugs@gnats.NetBSD.org>
From: None <rkr@olib.org>
List: pkgsrc-bugs
Date: 06/02/2004 13:00:19
>Number: 25786
>Category: pkg
>Synopsis: ...pkgsrc/archivers/freeze: main() should return {int}.
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: pkg-manager
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed Jun 02 13:01:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator: Richard Rauch
>Release: pre-2.0 NetBSD-current.
>Organization:
>Environment:
(irrelavent; besides, I still can't paste into a links-gui form editor)
>Description:
This one is in the spirit of correcting annoying warnings. (^&
In freeze.c, main, line 183, the compiler gives a warning about the bogus
{void} return type that freeze uses for main().
Since they call exit() at the end of main() rather than returning,
the mistake is not a practical problem. Still...
>How-To-Repeat:
Log a build of freeze, and look for warnings.
>Fix:
Since lins-gui does not work for me to paste into forms, and the changes
are trivial (2 lines), I'll point them out rather than provide my patch.
On about line 179: s/void/int/
On about line 690 (after exit(), before the close-brace), insert line:
return exit_stat;
>Release-Note:
>Audit-Trail:
>Unformatted: