>Number:         25752
>Category:       pkg
>Synopsis:       libmatroska's build does not pick up pkgview dependencies from buildlink3
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun May 30 12:28:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     Joachim Kuebart
>Release:        NetBSD 2.0B from around April 2, 2004.
>Organization:
>Environment:
	
	
System: NetBSD jaja 2.0B NetBSD 2.0B (ALPHA-$Revision: 1.191 $) #10: Thu Apr 22 17:37:18 CEST 2004 joki@jaja:/home/joki/NetBSD/compile/JAJA alpha
Architecture: alpha
Machine: alpha
libmatroska-0.7.0
>Description:
The libmatroska build Makefile does not pass through the CXXFLAGS set by
the buildlink3 framework. As a consequence, libebml is not picked up
properly in a pkgview setting.
	
>How-To-Repeat:
Build and install a pkgview'd libebml and attempt to build a
pkgview'd libmatroska. The build fails due to insufficient
directories in CXXFLAGS. Note that both packages are not pkgview'd
yet, but see my mail to tech-pkg from Sun May 30.
	
>Fix:
	
Change the package Makefile to pass CXXFLAGS through to make. Change the
libmatroska Makefile to not override but append to existing CXXFLAGS.

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/multimedia/libmatroska/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile	16 May 2004 09:49:14 -0000	1.4
+++ Makefile	30 May 2004 12:25:21 -0000
@@ -9,12 +9,15 @@
 HOMEPAGE=	http://www.matroska.org/
 COMMENT=	Extensible open standard Audio/Video container format
 
+PKG_INSTALLATION_TYPES=	overwrite pkgviews
+
 USE_BUILDLINK3=	yes
 USE_GNU_TOOLS+=	make
 USE_LANGUAGES=	c++
 
 NO_CONFIGURE=	yes
 MAKEFLAGS+=	prefix="${PREFIX}"
+MAKE_ENV+=	CXXFLAGS="${CXXFLAGS}"
 BUILD_DIRS=	${WRKDIR}/${DISTNAME}/make/linux
 
 ONLY_FOR_COMPILER=	gcc
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/multimedia/libmatroska/distinfo,v
retrieving revision 1.3
diff -u -r1.3 distinfo
--- distinfo	16 May 2004 09:50:57 -0000	1.3
+++ distinfo	30 May 2004 12:25:21 -0000
@@ -5,3 +5,4 @@
 SHA1 (patch-aa) = 1b39f10c5d50091d7875d5e60c3e9b09d187a7a1
 SHA1 (patch-ab) = 41178badc83063d898939ac6a334bf6af73d0f42
 SHA1 (patch-ac) = b3f5aff05ea55ca3dbdc6f0f20656080b1dfff3d
+SHA1 (patch-ad) = 48541e51eeb4b25c9797e7bd08571db8f9a5a795

New file patches/patch-ad:
$NetBSD$

--- make/linux/Makefile.orig	2004-05-14 16:01:51.000000000 +0200
+++ make/linux/Makefile	2004-05-14 13:44:21.000000000 +0200
@@ -36,8 +36,8 @@
 ifeq (yes,$(DEBUG))
 DEBUGFLAGS=-g -DDEBUG
 endif
-CXXFLAGS=$(DEBUGFLAGS) -Wall -Wno-unknown-pragmas -ansi -fno-gnu-keywords -D_GNU_SOURCE -Wshadow
-LDFLAGS=-L. -L$(LIBEBML_LIB_DIR)
+CXXFLAGS+=$(DEBUGFLAGS) -Wall -Wno-unknown-pragmas -ansi -fno-gnu-keywords -D_GNU_SOURCE -Wshadow
+LDFLAGS+=-L. -L$(LIBEBML_LIB_DIR)
 
 SRC_DIR=$(CWD)/../../src/
 INCLUDE_DIR=$(CWD)/../../matroska
>Release-Note:
>Audit-Trail:
>Unformatted: