Subject: pkg/25725: Syntax errors prevent compilation of textproc/dict-dictionaries with gcc 3.4.0
To: None <gnats-bugs@gnats.NetBSD.org>
From: None <shannonjr@netbsd.org>
List: pkgsrc-bugs
Date: 05/27/2004 05:29:32
>Number:         25725
>Category:       pkg
>Synopsis:       Syntax errors prevent compilation of textproc/dict-dictionaries with gcc 3.4.0
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu May 27 11:30:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     John R. Shannon
>Release:        NetBSD 2.0_BETA
>Organization:
	netbsd.org
>Environment:
System: NetBSD colleen.internal.johnrshannon.com 2.0_BETA NetBSD 2.0_BETA (KERNEL) #0: Mon May 24 05:31:10 MDT 2004 root@colleen.internal.johnrshannon.com:/usr/obj/usr/src/sys/arch/i386/compile/KERNEL i386
Architecture: i386
Machine: i386
>Description:
	Four instances of missing argument list separator (comma) in one file
	and label at end of block in another file prevent successful build
	when gcc 3.4.0 is used as compiler.
>How-To-Repeat:
	Build with wip/gcc-3.4
>Fix:
	Two patches:


$NetBSD$

--- dict-web1913-1.4/libmaa/parse.c.orig	1998-02-22 12:32:36.000000000 -0700
+++ dict-web1913-1.4/libmaa/parse.c
@@ -75,7 +75,7 @@ void prs_file( const char *filename )
 
    if (!cpp) {
       if ((cpp = getenv( "KHEPERA_CPP" ))) {
-         PRINTF(MAA_PARSE,(__FUNCTION__ ": Using KHEPERA_CPP from %s\n",cpp));
+         PRINTF(MAA_PARSE,(__FUNCTION__, ": Using KHEPERA_CPP from %s\n",cpp));
       }
       
                                 /* Always look for gcc's cpp first, since
@@ -86,7 +86,7 @@ void prs_file( const char *filename )
          
          if (fread( buf, 1, 1023, tmp ) > 0) {
             if ((t = strchr( buf, '\n' ))) *t = '\0';
-            PRINTF(MAA_PARSE,(__FUNCTION__ ": Using GNU cpp from %s\n",buf));
+            PRINTF(MAA_PARSE,(__FUNCTION__, ": Using GNU cpp from %s\n",buf));
             cpp = str_find( buf );
             extra_options = "-nostdinc -nostdinc++";
          }
@@ -103,7 +103,7 @@ void prs_file( const char *filename )
          for (pt = cpps; **pt; pt++) {
             if (!access( *pt, X_OK )) {
                PRINTF(MAA_PARSE,
-                      (__FUNCTION__ ": Using system cpp from %s\n",*pt));
+                      (__FUNCTION__, ": Using system cpp from %s\n",*pt));
                cpp = *pt;
                break;
             }
@@ -123,7 +123,7 @@ void prs_file( const char *filename )
    sprintf( buffer, "%s -I. %s %s 2>/dev/null", cpp,
 	    _prs_cpp_options ? _prs_cpp_options : "", filename );
 
-   PRINTF(MAA_PARSE,(__FUNCTION__ ": %s\n",buffer));
+   PRINTF(MAA_PARSE,(__FUNCTION__, ": %s\n",buffer));
    if (!(yyin = popen( buffer, "r" )))
       err_fatal_errno( __FUNCTION__,
 		       "Cannot open \"%s\" for read\n", filename );


$NetBSD$

--- ./dict-misc-1.5/dictfmt.c.orig	1998-07-05 19:33:40.000000000 -0600
+++ ./dict-misc-1.5/dictfmt.c
@@ -465,6 +465,7 @@ int main( int argc, char **argv )
       fmt_string(buf);
       fmt_newline();
  skip:
+      ;
    }
    
    fmt_newheadword(NULL,0);
>Release-Note:
>Audit-Trail:
>Unformatted: