On Sat, 13 Jan 2007 23:43:16 +0100
Nicolas Joly <njoly@pasteur.fr> wrote:

> I just tested it on a HP Pavillion 7825, which has a VIA VT86C686A
> chipset; and i can report that it works (dmesg attached).
> 
> In the mean time, i noted a few things:
> 
> 1) dmesg output can be improved (by removing some extra newlines).
> 
> [...]
> uhub1: 2 ports with 2 removable, self powered
> viaenv0 at pci0 dev 7 function 4
> : VIA VT82C686A Hardware Monitor
> timecounter: Timecounter "viaenv0" frequency 3579545 Hz quality 1000
> viaenv0 24-bit timer
> 
> auvia0 at pci0 dev 7 function 5: VIA Technologies VT82C686A AC'97
> Audio (rev H) [...]

Fixed.
 
> 2) For consistency with other device descriptions, we should better
>    use `VIA Technologies' over `VIA' for vendor text.

Fixed.

> 3) The same timer does not show the same quality when attached from
>    ACPI and viaenv.
> 
> timecounter: Timecounter "ACPI-Safe" frequency 3579545 Hz quality 900
> ACPI-Safe 24-bit timer
> [...]
> timecounter: Timecounter "viaenv0" frequency 3579545 Hz quality 1000
> viaenv0 24-bit timer

Right, I think we could enable the ACPIPMT_BADLATCH flag in
acpipmtimer_attach() which forces the quality to 900 to be consistent
with ACPI.
 
> 4) in `viaenv_attach()', the comment about enabling hardware monitor
>    looks wrong, because the code to enable the HW is missing (but
>    correct according to the vt82c686 datasheet).

Fixed.

-- 
http://plog.xtrarom.org/
Juan RP's blog - NetBSD/pkgsrc news in Spanish